doc: improve crypto.randomUUID() text - #36830
Merged
Trott merged 1 commit intoJan 8, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
cjihrig
approved these changes
Jan 7, 2021
jasnell
approved these changes
Jan 7, 2021
aduh95
approved these changes
Jan 7, 2021
ChALkeR
approved these changes
Jan 7, 2021
Copy link
Copy Markdown
Member
|
Seems unnecessary to wait the full time to land. Fast-track? |
Sorry, something went wrong.
* Use present tense. * Remove "persistently" which suggests that the cache persists across Node.js runs. * Remove "pre-emptively". I think "proactively" is what was meant as nothing is being pre-empted here. Regardless of what the adverby should be, it seems unnecessary. PR-URL: nodejs#36830 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
* Use present tense. * Remove "persistently" which suggests that the cache persists across Node.js runs. * Remove "pre-emptively". I think "proactively" is what was meant as nothing is being pre-empted here. Regardless of what the adverby should be, it seems unnecessary. PR-URL: #36830 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js runs.
nothing is being pre-empted here. Regardless of what the adverby
should be, it seems unnecessary.