FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: use ESM syntax for WASI example by aduh95 · Pull Request #36848 · nodejs/node · GitHub

/ node Public

doc: use ESM syntax for WASI example - #36848

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:wasi-doc-esm
Jan 15, 2021
ConversationCommits (1)ChecksFiles changed
Merged

doc: use ESM syntax for WASI example#36848
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:wasi-doc-esm

Conversation

aduh95 commented Jan 8, 2021

Copy link
Copy Markdown
Contributor

Using top-level await and ESM makes sense here I think, and it makes the example easier to follow.

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 8, 2021

aduh95 commented Jan 12, 2021

Copy link
Copy Markdown
Contributor Author

@nodejs/wasi

gengjiawen reviewed Jan 13, 2021
View reviewed changes
Comment thread doc/api/wasi.md Outdated
gengjiawen approved these changes Jan 13, 2021
View reviewed changes

gengjiawen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

gengjiawen reviewed Jan 13, 2021
View reviewed changes
Comment thread doc/api/wasi.md Outdated
gengjiawen requested a review from cjihrig January 13, 2021 09:40

cjihrig commented Jan 13, 2021

Copy link
Copy Markdown
Contributor

Somehow this turned into 101 files being changed? If that's intentional, I think the commits should be split out into separate PRs.

aduh95 mentioned this pull request Jan 13, 2021
Merged

aduh95 commented Jan 13, 2021

Copy link
Copy Markdown
Contributor Author

Somehow this turned into 101 files being changed? If that's intentional, I think the commits should be split out into separate PRs.

There are two commits, one to add the TLA syntax to the linter, and one to make the change this PR is about. I'm opening #36911 to this PR about WASI docs only.

aduh95 added the blocked PRs that are blocked by other issues or PRs. label Jan 13, 2021
cjihrig approved these changes Jan 13, 2021
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The WASI docs change LGTM.

doc: use ESM syntax for WASI example
88a5426 
PR-URL: nodejs#36848
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
aduh95 merged commit 88a5426 into nodejs:master Jan 15, 2021

aduh95 commented Jan 15, 2021

Copy link
Copy Markdown
Contributor Author

Landed in 88a5426

aduh95 deleted the wasi-doc-esm branch January 15, 2021 23:35
aduh95 removed the blocked PRs that are blocked by other issues or PRs. label Jan 15, 2021
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
doc: use ESM syntax for WASI example
707b973 
PR-URL: #36848
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
ruyadorno mentioned this pull request Jan 22, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
doc: use ESM syntax for WASI example
308d361 
PR-URL: #36848
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
danielleadams mentioned this pull request May 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gengjiawen gengjiawen approved these changes
guybedford guybedford approved these changes
cjihrig cjihrig approved these changes
+1 more reviewer
devsnek devsnek left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL