FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: upgrade npm to 2.14.9 (for v4.x-staging) by othiym23 · Pull Request #3686 · nodejs/node · GitHub

/ node Public

deps: upgrade npm to 2.14.9 (for v4.x-staging) - #3686

Closed
othiym23 wants to merge 1 commit into
nodejs:v4.x-stagingfrom
npm:npm-2.14.9-node-v4.x
ConversationCommits (1)ChecksFiles changed
Closed

deps: upgrade npm to 2.14.9 (for v4.x-staging)#3686
othiym23 wants to merge 1 commit into
nodejs:v4.x-stagingfrom
npm:npm-2.14.9-node-v4.x

Conversation

othiym23 commented Nov 6, 2015

Copy link
Copy Markdown
Contributor

(Second verse, same as the first.)

Mostly just dependency upgrades and some small typo fixes. make test-npm passed, but again I'd like independent confirmation before merging.

r: @Fishrock123

othiym23 added npm Issues and PRs related to the npm client dependency or the npm registry. land-on-v4.x labels Nov 6, 2015

othiym23 commented Nov 6, 2015

Copy link
Copy Markdown
Contributor Author

I see the whitespace issues, and will rebase / apply the whitespace fix and push again.

othiym23 force-pushed the npm-2.14.9-node-v4.x branch from 7d1c5bd to 43566db Compare November 6, 2015 02:55

othiym23 commented Nov 6, 2015

Copy link
Copy Markdown
Contributor Author

Whitespace fix applied, and force-pushed. Also, reminded myself to read the release process docs more carefully in the future. ;)

MylesBorins commented Nov 6, 2015

Copy link
Copy Markdown
Contributor

All tests passing on my local machine 10.10.5 (make && make test-npm)

Fishrock123 commented Nov 6, 2015

Copy link
Copy Markdown
Contributor

@thealphanerd That's not necessarily accurate. Pre npm 3 (i.e. pre-v5.x) you need to also do (sudo) make install, as sometimes npm will be using the global node (and possibly itself).

Fishrock123 commented Nov 6, 2015

Copy link
Copy Markdown
Contributor

LGTM

MylesBorins commented Nov 6, 2015

Copy link
Copy Markdown
Contributor

thanks for the heads up @Fishrock123

jasnell commented Nov 9, 2015

Copy link
Copy Markdown
Member

LGTM

jasnell commented Nov 9, 2015

Copy link
Copy Markdown
Member

Will get this landed in v4.x-staging a bit later this week.

othiym23 added a commit that referenced this pull request Nov 15, 2015
deps: upgrade npm to 2.14.9
44d4a02 
Dependency upgrades.

PR-URL: #3686
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Nov 15, 2015

Copy link
Copy Markdown
Member

Landed in v4.x-staging in 44d4a02

jasnell closed this Nov 15, 2015
rvagg mentioned this pull request Nov 17, 2015
Closed
othiym23 added a commit that referenced this pull request Dec 4, 2015
deps: upgrade npm to 2.14.9
bc683d1 
Dependency upgrades.

PR-URL: #3686
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell mentioned this pull request Dec 17, 2015
Closed
othiym23 added a commit that referenced this pull request Dec 17, 2015
deps: upgrade npm to 2.14.9
a2ce384 
Dependency upgrades.

PR-URL: #3686
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

ChALkeR commented Dec 19, 2015

Copy link
Copy Markdown
Member

There was never a CI run for this, right?

See #4336 (comment)

jasnell commented Dec 19, 2015

Copy link
Copy Markdown
Member

Entirely possible.
On Dec 19, 2015 5:00 AM, "Сковорода Никита Андреевич" <
notifications@github.com> wrote:

There was never a CI run for this, right?

—
Reply to this email directly or view it on GitHub
#3686 (comment).

Fishrock123 commented Dec 21, 2015

Copy link
Copy Markdown
Contributor

@ChALkeR CI runs are mostly useless for these, except to see if it clones I guess.

MylesBorins commented Dec 21, 2015

Copy link
Copy Markdown
Contributor

should we have an npm CI run that run make test-npm

I should be able to spin that up on jenkins pretty quickly

othiym23 added a commit that referenced this pull request Dec 23, 2015
deps: upgrade npm to 2.14.9
25300d3 
Dependency upgrades.

PR-URL: #3686
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Fishrock123 commented Jan 4, 2016

Copy link
Copy Markdown
Contributor

@thealphanerd For 2.x it needs to do sudo make install first though.

wraithgar deleted the npm-2.14.9-node-v4.x branch June 26, 2025 15:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

npm Issues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL