FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

benchmark: fix http2 benchmarks by Trott · Pull Request #36871 · nodejs/node · GitHub

/ node Public

benchmark: fix http2 benchmarks - #36871

Merged
Trott merged 0 commit into
nodejs:masterfrom
Trott:fix-http2-benchmarks
Jan 11, 2021
ConversationCommits (0)ChecksFiles changed
Merged

benchmark: fix http2 benchmarks#36871
Trott merged 0 commit into
nodejs:masterfrom
Trott:fix-http2-benchmarks

Conversation

Trott commented Jan 10, 2021

Copy link
Copy Markdown
Member

Fixes: #36746

nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. http2 Issues or PRs related to the http2 subsystem. labels Jan 10, 2021
Trott mentioned this pull request Jan 10, 2021
Closed
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 10, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2021

nodejs-github-bot commented Jan 10, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35424/

Trott commented Jan 10, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

Welp...I tried running the http2 benchmarks with these changes and I still got EADDRNOTAVAIL...so the new theory is...uh...working on it....

Trott removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 10, 2021
Trott force-pushed the fix-http2-benchmarks branch from c78d88f to c89052d Compare January 10, 2021 19:02

Trott commented Jan 10, 2021

Copy link
Copy Markdown
Member Author

Looks like the http2 benchmarker emits errors on connection but the http and https benchmarkers swallow them. I've added a commit to swallow connection errors on http2, and will run the benchmarks now to see if that causes any surprising results.

Trott commented Jan 10, 2021

Copy link
Copy Markdown
Member Author

Looks like the http2 benchmarker emits errors on connection but the http and https benchmarkers swallow them. I've added a commit to swallow connection errors on http2, and will run the benchmarks now to see if that causes any surprising results.

That seems to be working.

nodejs-github-bot commented Jan 10, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35430/

nodejs-github-bot commented Jan 10, 2021 •
edited by Trott
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35431/ ✔️

Trott mentioned this pull request Jan 11, 2021
Closed
2 tasks

Trott commented Jan 11, 2021

Copy link
Copy Markdown
Member Author

I'd like to fast-track this so I can follow up on #36679 (comment). Please 👍 here to fast-track.

Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 11, 2021
Trott closed this Jan 11, 2021
Trott force-pushed the fix-http2-benchmarks branch from c89052d to 1c4fa9a Compare January 11, 2021 04:27

Trott commented Jan 11, 2021

Copy link
Copy Markdown
Member Author

Landed in 1c4fa9a

Trott deleted the fix-http2-benchmarks branch January 11, 2021 04:27
Trott merged commit 1c4fa9a into nodejs:master Jan 11, 2021
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
benchmark: fix http2 benchmarks
3ca7a78 
Fixes: #36746

PR-URL: #36871
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
benchmark: fix http2 benchmarks
c22efc5 
Fixes: #36746

PR-URL: #36871
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams mentioned this pull request May 3, 2021
Merged
Linkgoron mentioned this pull request May 24, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gireeshpunathil gireeshpunathil approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

benchmark Issues and PRs related to the benchmark subsystem. fast-track PRs that do not need to wait for 48 hours to land. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

http2 benchmark seems broken

4 participants

Back | FazBrowse Home | New Git URL