crypto: fix randomInt bias - #36894
Closed
tniessen wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Co-authored-by: Andrey Pechkurov <apechkurov@gmail.com>
3 tasks
Copy link
Copy Markdown
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/35470/ Infrastructure failure: 16:41:06 FATAL: Server returned HTTP response code: 502 for URL: https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/VersionSelectorScript.groovy?a 16:41:06 java.io.IOException: Server returned HTTP response code: 502 for URL: https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/VersionSelectorScript.groovy?a |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/35471/ Infrastructure failure: 16:42:04 + bash -ex -s before 16:42:04 + curl https://raw.githubusercontent.com/nodejs/build/master/jenkins/scripts/node-test-commit-pre.sh 16:42:04 % Total % Received % Xferd Average Speed Time Time Time Current 16:42:04 Dload Upload Total Spent Left Speed 16:42:04 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 18 100 18 0 0 86 0 --:--:-- --:--:-- --:--:-- 87 16:42:04 + connection failure 16:42:04 bash: line 1: connection: command not found 16:42:04 Build step 'Execute shell' marked build as failure |
Sorry, something went wrong.
puzpuzpuz
approved these changes
Jan 12, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Jan 12, 2021
Copy link
Copy Markdown
Member
Author
|
The asan failure seems related to #36779 and is unrelated to this change. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Landed in 4db9854, thanks for reviewing. |
Sorry, something went wrong.
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@puzpuzpuz found this issue in #35110 (comment). Opening a separate PR to make sure this fix can land and be backported quickly, if necessary.
This patch also changes a few comments and definitions to make the necessary conditions easier to understand.
The actual effect of this bias is small, but the mere existence of bias defeats the purpose of this function.
Refs: #34600