FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param is NaN by Lxxyx · Pull Request #36937 · nodejs/node · GitHub

/ node Public

perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param is NaN - #36937

Closed
Lxxyx wants to merge 1 commit into
nodejs:masterfrom
Lxxyx:fix-perf_hooks-histogram-error
ConversationCommits (1)ChecksFiles changed
Closed

perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param is NaN#36937
Lxxyx wants to merge 1 commit into
nodejs:masterfrom
Lxxyx:fix-perf_hooks-histogram-error

Conversation

Lxxyx commented Jan 15, 2021

Copy link
Copy Markdown
Member

Fixes: #36936

RaisinTen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 15, 2021

nodejs-github-bot commented Jan 15, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35561/

nodejs-github-bot commented Jan 18, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35599/

jasnell commented Jan 18, 2021

Copy link
Copy Markdown
Member

Landed in 59af4e6

jasnell closed this Jan 18, 2021
jasnell pushed a commit that referenced this pull request Jan 18, 2021
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…
59af4e6 
… is NaN

Fixes: #36936

PR-URL: #36937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Lxxyx deleted the fix-perf_hooks-histogram-error branch January 18, 2021 21:43
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…
327a2b7 
… is NaN

Fixes: #36936

PR-URL: #36937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
ruyadorno mentioned this pull request Jan 22, 2021
Merged
ruyadorno pushed a commit that referenced this pull request Jan 25, 2021
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…
3f75a60 
… is NaN

Fixes: #36936

PR-URL: #36937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request May 25, 2021
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…
579d199 
… is NaN

Fixes: #36936

PR-URL: #36937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request May 30, 2021
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…
bd298f7 
… is NaN

Fixes: #36936

PR-URL: #36937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…
38178b8 
… is NaN

Fixes: #36936

PR-URL: #36937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…
726ef40 
… is NaN

Fixes: #36936

PR-URL: #36937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

perf_hooks: histogram.percentile throw Assertion `(percentile) > (0)' failed when param is NaN

6 participants

Back | FazBrowse Home | New Git URL