FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix module.isPreloading documentation by aduh95 · Pull Request #36944 · nodejs/node · GitHub

/ node Public

doc: fix module.isPreloading documentation - #36944

Closed
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:doc-module-isPreloading
Closed

doc: fix module.isPreloading documentation#36944
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:doc-module-isPreloading

Conversation

aduh95 commented Jan 15, 2021
edited
Loading

Copy link
Copy Markdown
Contributor

Refs: #36263
Fixes: #36775

nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Jan 15, 2021
aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 17, 2021

jasnell commented Jan 18, 2021

Copy link
Copy Markdown
Member

Landed in 9d7fb22

jasnell closed this Jan 18, 2021
jasnell pushed a commit that referenced this pull request Jan 18, 2021
Fixes: #36775

PR-URL: #36944
Refs: #36263
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 deleted the doc-module-isPreloading branch January 18, 2021 22:38
aduh95 added a commit to aduh95/node that referenced this pull request Jan 18, 2021
Fixes: nodejs#36775

PR-URL: nodejs#36944
Refs: nodejs#36263
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
Fixes: #36775

PR-URL: #36944
Refs: #36263
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno mentioned this pull request Jan 22, 2021
ruyadorno pushed a commit that referenced this pull request Jan 25, 2021
Fixes: #36775

PR-URL: #36944
Refs: #36263
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Apr 25, 2021
Fixes: #36775

PR-URL: #36944
Backport-PR-URL: #36988
Refs: #36263
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added backported-to-v14.x and removed author ready PRs that have at least one approval, no outstanding review comments, and a CI started. backport-open-v14.x labels Apr 25, 2021
danielleadams mentioned this pull request May 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

module.isPreloading doc doesn't match implementation

7 participants


Back | FazBrowse Home | New Git URL