FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v14.x Backport] crypto: implement randomuuid by jasnell · Pull Request #36945 · nodejs/node · GitHub

/ node Public

[v14.x Backport] crypto: implement randomuuid - #36945

Closed
jasnell wants to merge 1 commit into
nodejs:v14.x-stagingfrom
jasnell:backport-randomUUID-v14.x
Closed

[v14.x Backport] crypto: implement randomuuid#36945
jasnell wants to merge 1 commit into
nodejs:v14.x-stagingfrom
jasnell:backport-randomUUID-v14.x

Conversation

jasnell commented Jan 15, 2021

Copy link
Copy Markdown
Member

Signed-off-by: James M Snell jasnell@gmail.com
Original-PR-URL: #36729

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v14.x labels Jan 15, 2021
jasnell changed the title crypto: implement randomuuid [v14.x Backport] crypto: implement randomuuid Jan 15, 2021
jasnell added semver-minor PRs that contain new features and should be released in the next minor version. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 15, 2021

jasnell commented Jan 18, 2021

Copy link
Copy Markdown
Member Author

/cc @nodejs/backporters @nodejs/releasers ...

Copy link
Copy Markdown
Collaborator

jasnell removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2021
jasnell added a commit that referenced this pull request Jan 22, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
Original-PR-URL: #36729
PR-URL: #36945
Reviewed-By: Ben Coe <bencoe@gmail.com>

jasnell commented Jan 22, 2021

Copy link
Copy Markdown
Member Author

Landed in 3aeaaea

jasnell closed this Jan 22, 2021

Copy link
Copy Markdown
Contributor

@jasnell we usually do some degree of consensus building with @nodejs/lts prior to backporting semver-minor commits and we generally have it back longer than 14 days prior to a backport (more often multiple months).

Is this an experimental feature?

jasnell commented Jan 23, 2021

Copy link
Copy Markdown
Member Author

Feel free to revert if necessary

Copy link
Copy Markdown
Member

I'm preparing a patch release of v14 for this week (the plan was to keep this one intentionally small to just address some bugs and pull in an npm update). For ease of preparing the patch release - I'll probably temporarily drop the commit from the staging branch and reopen.

If there are no concerns from @nodejs/lts, i'll aim to re-land on staging after the patch release has gone out? The following/February release is scheduled to be a minor (nodejs/Release#567), and by the time of that release it'll probably have been out in v15 for a while (1 month+).

jasnell commented Feb 22, 2021

Copy link
Copy Markdown
Member Author

@MylesBorins @BethGriggs ... What's the timeline on this landing in 14.x again?

Copy link
Copy Markdown
Member

We do not yet have a volunteer to prepare the next planned release of Node.js 14. The upcoming security release has pushed the schedule out a little too.

We can pull this into staging ready to go out in the next release (which is due to be a minor). But unfortunately the actual release might be a while off, bearing in mind we'll need volunteer(s), and we've previously aimed for 2-3 weeks release candidate phase for minors.

(It's on my list to try and land some commits on v14.x-staging, but I cannot commit the time to preparing the whole release atm.)

jasnell commented Apr 21, 2021

Copy link
Copy Markdown
Member Author

@nodejs/releasers ... any updates on when this might land in 14.x?

targos commented Apr 21, 2021

Copy link
Copy Markdown
Member

@jasnell when someone takes the time to prepare the next semver-minor release.

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#36729
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
targos force-pushed the backport-randomUUID-v14.x branch from b049920 to ab5e466 Compare April 24, 2021 12:36

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

targos pushed a commit that referenced this pull request Apr 25, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36729
Backport-PR-URL: #36945
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>

targos commented Apr 25, 2021

Copy link
Copy Markdown
Member

Landed in 08f9130

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL