FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[docs] Fix grammar and link to QUIC by dandv · Pull Request #36959 · nodejs/node · GitHub

/ node Public

[docs] Fix grammar and link to QUIC - #36959

Closed
dandv wants to merge 1 commit into
nodejs:masterfrom
dandv:patch-2
ConversationCommits (1)ChecksFiles changed
Closed

[docs] Fix grammar and link to QUIC#36959
dandv wants to merge 1 commit into
nodejs:masterfrom
dandv:patch-2

Conversation

dandv commented Jan 16, 2021

Copy link
Copy Markdown
Contributor

No description provided.

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 16, 2021
gengjiawen previously requested changes Jan 16, 2021
View reviewed changes

gengjiawen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Typo: QUICK -> QUIC

dandv changed the title [docs] Fix grammar and link to QUICK [docs] Fix grammar and link to QUIC Jan 16, 2021

aduh95 commented Jan 16, 2021

Copy link
Copy Markdown
Contributor

Typo: QUICK -> QUIC

This can be fixed when landing, to avoid having to run another CI just to fix the commit message.

Trott approved these changes Jan 16, 2021
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM although I wonder if the link should be https://developer.mozilla.org/en-US/docs/Glossary/QUIC rather than Wikipedia.

aduh95 commented Jan 18, 2021

Copy link
Copy Markdown
Contributor

@gengjiawen do you want to retract or rephrase your objection? Per our policy, objection must include a clear reason for that objection.

gengjiawen reviewed Jan 18, 2021
View reviewed changes

gengjiawen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Whoever land this please fix commit message.

gengjiawen self-requested a review January 18, 2021 11:38

gengjiawen commented Jan 18, 2021

Copy link
Copy Markdown
Member

@gengjiawen do you want to retract or rephrase your objection? Per our policy, objection must include a clear reason for that objection.

My objection is clear. But also this can be fixed by commiter, I have dismissed my objection with a comment.

RaisinTen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 18, 2021
aduh95 dismissed gengjiawen’s stale review January 18, 2021 14:04

They dismissed their objection in a comment above.

aduh95 commented Jan 18, 2021

Copy link
Copy Markdown
Contributor

Landed in 75a73c4

aduh95 closed this Jan 18, 2021
aduh95 pushed a commit that referenced this pull request Jan 18, 2021
doc: fix grammar and link to QUIC in changelog
75a73c4 
PR-URL: #36959
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
dandv deleted the patch-2 branch January 19, 2021 03:02
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
doc: fix grammar and link to QUIC in changelog
120db2c 
PR-URL: #36959
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
ruyadorno mentioned this pull request Jan 22, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
aduh95 aduh95 approved these changes
HarshithaKP HarshithaKP approved these changes
gengjiawen Awaiting requested review from gengjiawen
+1 more reviewer
PoojaDurgad PoojaDurgad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL