FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update ICU to 68.2 by targos · Pull Request #36980 · nodejs/node · GitHub

/ node Public

deps: update ICU to 68.2 - #36980

Closed
targos wants to merge 3 commits into
nodejs:masterfrom
targos:icu4c-68.2
ConversationCommits (3)ChecksFiles changed
Closed

deps: update ICU to 68.2#36980
targos wants to merge 3 commits into
nodejs:masterfrom
targos:icu4c-68.2

Conversation

targos commented Jan 18, 2021

Copy link
Copy Markdown
Member
  • deps: update ICU to 68.2
  • doc: fix maintaining ICU guide
  • tools: cleanup old ICU version-specific fixes

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 18, 2021

nodejs-github-bot commented Jan 18, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35597/

richardlau commented Jan 18, 2021

Copy link
Copy Markdown
Member

The dont-land-* labels are due to the tools: cleanup old ICU version-specific fixes commit.

aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 18, 2021
targos added a commit that referenced this pull request Jan 20, 2021
deps: update ICU to 68.2
5faffd8 
Refs: https://github.com/unicode-org/icu/releases/tag/release-68-2

PR-URL: #36980
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Jan 20, 2021
doc: fix maintaining ICU guide
37e0a0d 
PR-URL: #36980
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Jan 20, 2021
tools: cleanup old ICU version-specific fixes
900c9f5 
Our current minimum ICU is 67, so we don't need to support those anymore

PR-URL: #36980
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

targos commented Jan 20, 2021

Copy link
Copy Markdown
Member Author

Landed in e3e054d...900c9f5

targos closed this Jan 20, 2021
targos deleted the icu4c-68.2 branch January 20, 2021 15:37
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
deps: update ICU to 68.2
d684cbd 
Refs: https://github.com/unicode-org/icu/releases/tag/release-68-2

PR-URL: #36980
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
doc: fix maintaining ICU guide
95889c1 
PR-URL: #36980
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
tools: cleanup old ICU version-specific fixes
6125701 
Our current minimum ICU is 67, so we don't need to support those anymore

PR-URL: #36980
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
ruyadorno mentioned this pull request Jan 22, 2021
Merged
ruyadorno pushed a commit that referenced this pull request Jan 25, 2021
deps: update ICU to 68.2
ef3a5f6 
Refs: https://github.com/unicode-org/icu/releases/tag/release-68-2

PR-URL: #36980
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
ruyadorno pushed a commit that referenced this pull request Jan 25, 2021
doc: fix maintaining ICU guide
4b952d8 
PR-URL: #36980
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
ruyadorno pushed a commit that referenced this pull request Jan 25, 2021
tools: cleanup old ICU version-specific fixes
6ef54bb 
Our current minimum ICU is 67, so we don't need to support those anymore

PR-URL: #36980
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Mar 3, 2021
deps: update ICU to 68.2
966eee7 
Refs: https://github.com/unicode-org/icu/releases/tag/release-68-2

PR-URL: #36980
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Mar 3, 2021
doc: fix maintaining ICU guide
efb88ee 
PR-URL: #36980
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Mar 3, 2021
tools: cleanup old ICU version-specific fixes
8899f47 
Our current minimum ICU is 67, so we don't need to support those anymore

PR-URL: #36980
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
137717unity mentioned this pull request Nov 9, 2022
Open
baby636 mentioned this pull request Nov 9, 2022
Open
ron-a20 mentioned this pull request Nov 9, 2022
Open
kissofire mentioned this pull request Mar 18, 2023
Open
molllyn1 mentioned this pull request Jun 8, 2023
Open
This was referenced Jun 8, 2023
Open
Open
ron-a20 mentioned this pull request Jun 8, 2023
Open
baby636 mentioned this pull request Jun 9, 2023
Open
137717unity mentioned this pull request Jun 9, 2023
Open
wedataintelligence mentioned this pull request Jun 9, 2023
Open
ron-a20 mentioned this pull request Jun 21, 2023
Open
137717unity mentioned this pull request Jun 21, 2023
Open
wedataintelligence mentioned this pull request Jun 21, 2023
Open
baby636 mentioned this pull request Jun 23, 2023
Open
kissofire mentioned this pull request Jun 25, 2023
Open
ron-a20 mentioned this pull request Oct 1, 2023
Open
aliceUnhinged613 mentioned this pull request Oct 1, 2023
Open
kissofire mentioned this pull request Oct 1, 2023
Open
wedataintelligence mentioned this pull request Oct 2, 2023
Open
molllyn1 mentioned this pull request Oct 2, 2023
Open
137717unity mentioned this pull request Oct 2, 2023
Open
baby636 mentioned this pull request Oct 2, 2023
Open
wedataintelligence mentioned this pull request Feb 23, 2024
Open
kissofire mentioned this pull request Feb 23, 2024
Open
molllyn1 mentioned this pull request Feb 23, 2024
Open
baby636 mentioned this pull request Feb 23, 2024
Open
137717unity mentioned this pull request Feb 23, 2024
Open
ron-a20 mentioned this pull request Feb 24, 2024
Open
aliceUnhinged613 mentioned this pull request Feb 24, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
cjihrig cjihrig approved these changes
richardlau richardlau approved these changes
BethGriggs BethGriggs approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL