FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: mark flaky tests on IBM i by richardlau · Pull Request #36986 · nodejs/node · GitHub

/ node Public

test: mark flaky tests on IBM i - #36986

Closed
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:ibmi
ConversationCommits (1)ChecksFiles changed
Closed

test: mark flaky tests on IBM i#36986
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:ibmi

Conversation

richardlau commented Jan 18, 2021

Copy link
Copy Markdown
Member

Refs: #34410
Refs: #36925
Refs: #36929

Underlying issues still need to be investigated, but this will prevent these
failures from failing the daily builds.

cc @nodejs/platform-ibmi

nodejs-github-bot added addons Issues and PRs related to native addons. test Issues and PRs related to the tests. labels Jan 18, 2021

nodejs-github-bot commented Jan 18, 2021 •
edited by richardlau
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35606/ (✔️)
IBM i CI: https://ci.nodejs.org/job/node-test-commit-ibmi/228/ (yellow (as expected))

richardlau added the ibm i Issues and PRs related to the IBM i platform. label Jan 18, 2021
richardlau mentioned this pull request Jan 18, 2021
Closed
richardlau added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 18, 2021
jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 18, 2021

jasnell commented Jan 18, 2021

Copy link
Copy Markdown
Member

Shouldn't be any reason for this to wait the full time to land. 👍🏻 to fast-track

mhdawson approved these changes Jan 18, 2021
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Trott pushed a commit that referenced this pull request Jan 19, 2021
test: mark flaky tests on IBM i
863ec7d 
PR-URL: #36986
Refs: #34410
Refs: #36925
Refs: #36929
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Trott commented Jan 19, 2021

Copy link
Copy Markdown
Member

Landed in 863ec7d

Trott closed this Jan 19, 2021
richardlau deleted the ibmi branch January 19, 2021 14:42
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
test: mark flaky tests on IBM i
3a122aa 
PR-URL: #36986
Refs: #34410
Refs: #36925
Refs: #36929
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
ruyadorno mentioned this pull request Jan 22, 2021
Merged
ruyadorno pushed a commit that referenced this pull request Jan 25, 2021
test: mark flaky tests on IBM i
7acea78 
PR-URL: #36986
Refs: #34410
Refs: #36925
Refs: #36929
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
test: mark flaky tests on IBM i
5408f51 
PR-URL: #36986
Refs: #34410
Refs: #36925
Refs: #36929
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams mentioned this pull request May 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
cjihrig cjihrig approved these changes
+1 more reviewer
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. ibm i Issues and PRs related to the IBM i platform. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL