FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

benchmark: improve explanations in R script by tniessen · Pull Request #36995 · nodejs/node · GitHub

/ node Public

benchmark: improve explanations in R script - #36995

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:benchmark-r-explanations
Closed

benchmark: improve explanations in R script#36995
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:benchmark-r-explanations

Conversation

Copy link
Copy Markdown
Member

Just a few minor improvements to the comments in compare.R.

tniessen added the benchmark Issues and PRs related to the benchmark subsystem. label Jan 19, 2021
PoojaDurgad added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 20, 2021
jasnell pushed a commit that referenced this pull request Jan 23, 2021
PR-URL: #36995
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Jan 23, 2021

Copy link
Copy Markdown
Member

Landed in ea2e2df

jasnell closed this Jan 23, 2021
tniessen deleted the benchmark-r-explanations branch January 23, 2021 15:28
tniessen removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 23, 2021
targos pushed a commit that referenced this pull request Feb 2, 2021
PR-URL: #36995
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Feb 2, 2021
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #36995
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request May 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmark Issues and PRs related to the benchmark subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL