dgram: support AbortSignal in createSocket - #37026
Closed
Linkgoron wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Linkgoron
force-pushed
the
dgram-socket-abortcontroller
branch
from
5d1646c to
456f2c3
Compare
January 22, 2021 21:18
benjamingr
reviewed
Jan 22, 2021
Comment thread
lib/dgram.js
Outdated
benjamingr
reviewed
Jan 22, 2021
benjamingr
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Good job, left a question - overall lgtm with the question resolved
Sorry, something went wrong.
Linkgoron
force-pushed
the
dgram-socket-abortcontroller
branch
from
456f2c3 to
570575a
Compare
January 22, 2021 21:38
benjamingr
approved these changes
Jan 22, 2021
Trott
approved these changes
Jan 23, 2021
jasnell
reviewed
Jan 25, 2021
Comment thread
lib/dgram.js
| if (signal.aborted) { | ||
| onAborted(); | ||
| } else { | ||
| signal.addEventListener('abort', onAborted); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggested change
| signal.addEventListener('abort', onAborted); | |
| signal.addEventListener('abort', onAborted, { once: true }); |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I think this is fine, once just creates the impression that it removes the abort listener on 'abort' but you'd need the removeEventListener anyway for the "server closed for another reason" case.
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
benjamingr
pushed a commit
that referenced
this pull request
Jan 25, 2021
PR-URL: #37026 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 2, 2021
PR-URL: #37026 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
added a commit
that referenced
this pull request
Feb 2, 2021
Notable changes: crypto: * (SEMVER-MINOR) add generatePrime/checkPrime (James M Snell) #36997 * (SEMVER-MINOR) experimental (Ed/X)25519/(Ed/X)448 support (James M Snell) #36879 deps: * upgrade npm to 7.5.0 (Ruy Adorno) #37117 dgram: * (SEMVER-MINOR) support AbortSignal in createSocket (Nitzan Uziely) #37026 doc: * add Zijian Liu to collaborators (ZiJian Liu) #37075 esm: * deprecate legacy main lookup for modules (Guy Bedford) #36918 readline: * (SEMVER-MINOR) add history event and option to set initial history (Mattias Runge-Broberg) #33662 * (SEMVER-MINOR) add support for the AbortController to the question method (Mattias Runge-Broberg) #33676 PR-URL: #37183
targos
added a commit
that referenced
this pull request
Feb 2, 2021
Notable changes: crypto: * (SEMVER-MINOR) add generatePrime/checkPrime (James M Snell) #36997 * (SEMVER-MINOR) experimental (Ed/X)25519/(Ed/X)448 support (James M Snell) #36879 deps: * upgrade npm to 7.5.0 (Ruy Adorno) #37117 dgram: * (SEMVER-MINOR) support AbortSignal in createSocket (Nitzan Uziely) #37026 doc: * add Zijian Liu to collaborators (ZiJian Liu) #37075 esm: * deprecate legacy main lookup for modules (Guy Bedford) #36918 readline: * (SEMVER-MINOR) add history event and option to set initial history (Mattias Runge-Broberg) #33662 * (SEMVER-MINOR) add support for the AbortController to the question method (Mattias Runge-Broberg) #33676 PR-URL: #37183
targos
added a commit
that referenced
this pull request
Feb 2, 2021
Notable changes: crypto: * (SEMVER-MINOR) add generatePrime/checkPrime (James M Snell) #36997 * (SEMVER-MINOR) experimental (Ed/X)25519/(Ed/X)448 support (James M Snell) #36879 deps: * upgrade npm to 7.5.0 (Ruy Adorno) #37117 dgram: * (SEMVER-MINOR) support AbortSignal in createSocket (Nitzan Uziely) #37026 doc: * add Zijian Liu to collaborators (ZiJian Liu) #37075 esm: * deprecate legacy main lookup for modules (Guy Bedford) #36918 readline: * (SEMVER-MINOR) add history event and option to set initial history (Mattias Runge-Broberg) #33662 * (SEMVER-MINOR) add support for the AbortController to the question method (Mattias Runge-Broberg) #33676 PR-URL: #37183
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 30, 2021
PR-URL: nodejs#37026 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dgram: support AbortSignal in createSocket
Add AbortSignal support to dgram.createSocket. Added signal to the createSocket options, which calls close on the socket when aborted.