doc: list Unsupported Directory Import resolve err - #37032
Closed
guybedford wants to merge 3 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@nodejs/modules |
Sorry, something went wrong.
Trott
reviewed
Jan 23, 2021
Comment thread
doc/api/esm.md
Outdated
Trott
approved these changes
Jan 23, 2021
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with spelling fix.
Sorry, something went wrong.
lpinca
approved these changes
Jan 23, 2021
Co-authored-by: Rich Trott <rtrott@gmail.com>
guybedford
added a commit
that referenced
this pull request
Jan 25, 2021
PR-URL: #37032 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 2, 2021
PR-URL: #37032 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #37032 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the documentation of the resolver specification to include the Unsupported Directory Import in ths list of errors provided at the top of the specification, to ensure this list remains exhaustive of all the errors that might be thrown by the resolver.