FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[15.x] Revert "stream: fix .end() error propagation" by mcollina · Pull Request #37060 · nodejs/node · GitHub

/ node Public

[15.x] Revert "stream: fix .end() error propagation" - #37060

Closed
mcollina wants to merge 1 commit into
nodejs:v15.x-stagingfrom
mcollina:revert-36817-v15
ConversationCommits (1)ChecksFiles changed
Closed

[15.x] Revert "stream: fix .end() error propagation"#37060
mcollina wants to merge 1 commit into
nodejs:v15.x-stagingfrom
mcollina:revert-36817-v15

Conversation

mcollina commented Jan 25, 2021

Copy link
Copy Markdown
Member

This reverts commit 4c819d6.

Fixes #37027

mcollina commented Jan 25, 2021

Copy link
Copy Markdown
Member Author

cc @lpinca @danielleadams

mcollina requested review from dnlup and ronag January 25, 2021 08:34

nodejs-github-bot commented Jan 25, 2021 •
edited by BethGriggs
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35722/ ✅

Trott commented Jan 31, 2021

Copy link
Copy Markdown
Member

We should probably add a test for #37027. (Doesn't have to be here/now, though.)

Trott commented Jan 31, 2021

Copy link
Copy Markdown
Member

Is the idea to land this again, but as a semver-major? Or to just leave it as it is?

ronag commented Jan 31, 2021

Copy link
Copy Markdown
Member

Is the idea to land this again, but as a semver-major? Or to just leave it as it is?

Revert on 15 leave on master

jasnell changed the title Revert "stream: fix .end() error propagation" [15.x] Revert "stream: fix .end() error propagation" Feb 1, 2021

danielleadams commented Feb 15, 2021

Copy link
Copy Markdown
Contributor

Landed in d2a487e

danielleadams pushed a commit that referenced this pull request Feb 15, 2021
Revert "stream: fix .end() error propagation"
d2a487e 
This reverts commit 4c819d6.

PR-URL: #37060
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
mcollina closed this Feb 15, 2021
This was referenced Feb 16, 2021
Closed
Merged
lpinca mentioned this pull request Mar 5, 2021
Closed
mcollina deleted the revert-36817-v15 branch March 5, 2021 10:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
lpinca lpinca approved these changes
ronag ronag approved these changes
BethGriggs BethGriggs approved these changes
+2 more reviewers
danielleadams danielleadams approved these changes
dnlup dnlup approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL