FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tls: add ability to get cert/peer cert as X509Certificate object by jasnell · Pull Request #37070 · nodejs/node · GitHub

/ node Public

tls: add ability to get cert/peer cert as X509Certificate object - #37070

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:tls_wrap_x509certificate
ConversationCommits (1)ChecksFiles changed
Closed

tls: add ability to get cert/peer cert as X509Certificate object#37070
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:tls_wrap_x509certificate

Conversation

jasnell commented Jan 26, 2021

Copy link
Copy Markdown
Member

Adds new getX509Certificate() and getPeerX509Certificate() as options on TLSSocket to get the cert/peercert as the new X509Certificate object.

Signed-off-by: James M Snell jasnell@gmail.com

jasnell added tls Issues and PRs related to the tls subsystem. crypto Issues and PRs related to the crypto subsystem. semver-minor PRs that contain new features and should be released in the next minor version. labels Jan 26, 2021
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jan 26, 2021

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Jan 26, 2021 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35757/ 💚

tniessen reviewed Jan 27, 2021
View reviewed changes
Comment thread doc/api/crypto.md Outdated
jasnell force-pushed the tls_wrap_x509certificate branch from 29874e0 to c3dd21b Compare January 27, 2021 14:41
jasnell requested a review from tniessen January 27, 2021 14:41

nodejs-github-bot commented Jan 27, 2021 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35782/ 💚

jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 27, 2021
Trott reviewed Jan 31, 2021
View reviewed changes
Comment thread doc/api/crypto.md Outdated
Trott reviewed Jan 31, 2021
View reviewed changes
Comment thread doc/api/tls.md Outdated
tls: add ability to get cert/peer cert as X509Certificate object
89bae06 
Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell force-pushed the tls_wrap_x509certificate branch from fcc254f to 89bae06 Compare January 31, 2021 15:37

nodejs-github-bot commented Jan 31, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35841/

tniessen commented Jan 31, 2021

Copy link
Copy Markdown
Member

CI is green. It would be great to get feedback from people with more experience with TLS than me, @nodejs/crypto. Apart from that, this is ready to land.

jasnell commented Feb 2, 2021

Copy link
Copy Markdown
Member Author

Landed in c973d50

jasnell closed this Feb 2, 2021
jasnell added a commit that referenced this pull request Feb 2, 2021
tls: add ability to get cert/peer cert as X509Certificate object
c973d50 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #37070
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
tls: add ability to get cert/peer cert as X509Certificate object
dc84c18 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #37070
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
danielleadams added a commit that referenced this pull request Feb 16, 2021
2021-02-16, Version 15.9.0 (Current)
5133659 
Notable Changes:

* crypto:
  * add keyObject.export() 'jwk' format option (Filip Skokan) #37081
* deps:
  * upgrade to libuv 1.41.0 (Colin Ihrig) #37360
* doc:
  * add dmabupt to collaborators (Xu Meng) #37377
  * refactor fs docs structure (James M Snell) #37170
* fs:
  * add fsPromises.watch() (James M Snell) #37179
  * use a default callback for fs.close() (James M Snell) #37174
  * add AbortSignal support to watch (Benjamin Gruenbaum) #37190
* perf_hooks:
  * introduce createHistogram (James M Snell) #37155
* stream:
  * improve Readable.from error handling (Benjamin Gruenbaum) #37158
* timers:
  * introduce setInterval async iterator (linkgoron) #37153
* tls:
  * add ability to get cert/peer cert as X509Certificate object (James M Snell) #37070
This was referenced Feb 16, 2021
Closed
Merged
danielleadams added a commit that referenced this pull request Feb 17, 2021
2021-02-17, Version 15.9.0 (Current)
889ffde 
Notable Changes:

* crypto:
  * add keyObject.export() 'jwk' format option (Filip Skokan) #37081
* deps:
  * upgrade to libuv 1.41.0 (Colin Ihrig) #37360
* doc:
  * add dmabupt to collaborators (Xu Meng) #37377
  * refactor fs docs structure (James M Snell) #37170
* fs:
  * add fsPromises.watch() (James M Snell) #37179
  * use a default callback for fs.close() (James M Snell) #37174
  * add AbortSignal support to watch (Benjamin Gruenbaum) #37190
* perf_hooks:
  * introduce createHistogram (James M Snell) #37155
* stream:
  * improve Readable.from error handling (Benjamin Gruenbaum) #37158
* timers:
  * introduce setInterval async iterator (linkgoron) #37153
* tls:
  * add ability to get cert/peer cert as X509Certificate object (James M Snell) #37070
danielleadams added a commit that referenced this pull request Feb 17, 2021
2021-02-17, Version 15.9.0 (Current)
877f66e 
PR-URL: #37406

Notable Changes:

* crypto:
  * add keyObject.export() jwk format option (Filip Skokan) #37081
* deps:
  * upgrade to libuv 1.41.0 (Colin Ihrig) #37360
* doc:
  * add dmabupt to collaborators (Xu Meng) #37377
  * refactor fs docs structure (James M Snell) #37170
* fs:
  * add fsPromises.watch() (James M Snell) #37179
  * use a default callback for fs.close() (James M Snell) #37174
  * add AbortSignal support to watch (Benjamin Gruenbaum) #37190
* perf_hooks:
  * introduce createHistogram (James M Snell) #37155
* stream:
  * improve Readable.from error handling (Benjamin Gruenbaum) #37158
* timers:
  * introduce setInterval async iterator (linkgoron) #37153
* tls:
  * add ability to get cert/peer cert as X509Certificate object (James M Snell) #37070
danielleadams added a commit that referenced this pull request Feb 18, 2021
2021-02-17, Version 15.9.0 (Current)
3bf50a7 
PR-URL: #37406

Notable Changes:

* crypto:
  * add keyObject.export() jwk format option (Filip Skokan) #37081
* deps:
  * upgrade to libuv 1.41.0 (Colin Ihrig) #37360
* doc:
  * add dmabupt to collaborators (Xu Meng) #37377
  * refactor fs docs structure (James M Snell) #37170
* fs:
  * add fsPromises.watch() (James M Snell) #37179
  * use a default callback for fs.close() (James M Snell) #37174
  * add AbortSignal support to watch (Benjamin Gruenbaum) #37190
* perf_hooks:
  * introduce createHistogram (James M Snell) #37155
* stream:
  * improve Readable.from error handling (Benjamin Gruenbaum) #37158
* timers:
  * introduce setInterval async iterator (linkgoron) #37153
* tls:
  * add ability to get cert/peer cert as X509Certificate object (James M Snell) #37070
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott left review comments
panva panva approved these changes
tniessen tniessen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. semver-minor PRs that contain new features and should be released in the next minor version. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL