doc: use top-level await syntax in vm.md - #37077
Closed
aduh95 wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
lpinca
approved these changes
Jan 26, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
RaisinTen
reviewed
Jan 27, 2021
Comment thread
doc/api/vm.md
Outdated
RaisinTen
reviewed
Jan 27, 2021
Comment thread
doc/api/vm.md
Outdated
RaisinTen
approved these changes
Jan 27, 2021
jasnell
reviewed
Jan 27, 2021
Comment thread
doc/api/vm.md
Outdated
Copy link
Copy Markdown
Member
|
This would change the examples to be ones that cannot be placed in a .js file (let's say index.js) and run as node index.js. To me, that's a pretty big change and one we'd want to sort out across the docs. But maybe I'm wrong. @nodejs/documentation |
Sorry, something went wrong.
4 tasks
Copy link
Copy Markdown
Contributor
Author
|
Removed author ready label to try to get more opinions before landing. I've also opened #37162 to address the more general issue. |
Sorry, something went wrong.
aymen94
approved these changes
Feb 2, 2021
jasnell
approved these changes
Mar 5, 2021
jasnell
pushed a commit
that referenced
this pull request
Mar 5, 2021
PR-URL: #37077 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
PR-URL: #37077 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #37077 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLA allows us to use more concise example and get rid of IIFE async functions.