FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

util: fix infinite recursion during inspection by BridgeAR · Pull Request #37079 · nodejs/node · GitHub

/ node Public

util: fix infinite recursion during inspection - #37079

Closed
BridgeAR wants to merge 2 commits into
nodejs:masterfrom
BridgeAR:fix/37054
ConversationCommits (2)ChecksFiles changed
Closed

util: fix infinite recursion during inspection#37079
BridgeAR wants to merge 2 commits into
nodejs:masterfrom
BridgeAR:fix/37054

Conversation

BridgeAR commented Jan 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Member 
doc: fix outdated util inspect documentation and layout example

The documentation and layout example was not up to date with the
latest changes.

util: fix infinite recursion during inspection

A specially crafted object with circular structures behind getters
could cause a infinite recursion. This is now fixed by detecting the
objects as already visited.

Fixes: #37054

nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Jan 26, 2021
BridgeAR added the needs-ci PRs that need a full CI run. label Jan 26, 2021

This comment has been minimized.

Sign in to view
Lxxyx removed the needs-ci PRs that need a full CI run. label Jan 27, 2021
aduh95 reviewed Jan 29, 2021
View reviewed changes
Comment thread lib/internal/util/inspect.js Outdated
Comment thread lib/internal/util/inspect.js Outdated
Trott reviewed Jan 31, 2021
View reviewed changes
Comment thread doc/api/util.md Outdated
Trott approved these changes Jan 31, 2021
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with @aduh95's nits and my question about the doc sample code sorted.

BridgeAR commented Mar 19, 2021

Copy link
Copy Markdown
Member Author

PTAL

BridgeAR added 2 commits March 19, 2021 23:43
util: fix infinite recursion during inspection
486f8b8 
A specially crafted object with circular structures behind getters
could cause a infinite recursion. This is now fixed by detecting the
objects as already visited.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
doc: fix outdated util inspect documentation and layout example
7440350 
The documentation and layout example was not up to date with the
latest changes.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR requested review from Trott and aduh95 March 22, 2021 00:39
aduh95 approved these changes Mar 22, 2021
View reviewed changes

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

antsmartian added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 29, 2021

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Apr 30, 2021 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37845/ 💚

jasnell commented Apr 30, 2021

Copy link
Copy Markdown
Member

Landed in 3c6ff9e...5bfb6f0

jasnell closed this Apr 30, 2021
jasnell pushed a commit that referenced this pull request Apr 30, 2021
util: fix infinite recursion during inspection
942b76d 
A specially crafted object with circular structures behind getters
could cause a infinite recursion. This is now fixed by detecting the
objects as already visited.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #37079
Fixes: #37054
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
jasnell pushed a commit that referenced this pull request Apr 30, 2021
doc: fix outdated util inspect documentation and layout example
5bfb6f0 
The documentation and layout example was not up to date with the
latest changes.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #37079
Fixes: #37054
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request May 3, 2021
util: fix infinite recursion during inspection
ec5b06e 
A specially crafted object with circular structures behind getters
could cause a infinite recursion. This is now fixed by detecting the
objects as already visited.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #37079
Fixes: #37054
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request May 3, 2021
doc: fix outdated util inspect documentation and layout example
9258604 
The documentation and layout example was not up to date with the
latest changes.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #37079
Fixes: #37054
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos mentioned this pull request May 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
aduh95 aduh95 approved these changes
trivikr trivikr approved these changes
juanarbol juanarbol approved these changes
+1 more reviewer
antsmartian antsmartian approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

specific scenario causes infinite recursion in util.inspect (max stack size exceeded)

10 participants

Back | FazBrowse Home | New Git URL