FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: expose BaseObject::kInternalFieldCount in post-mortem metadata by joyeecheung · Pull Request #37111 · nodejs/node · GitHub

/ node Public

src: expose BaseObject::kInternalFieldCount in post-mortem metadata - #37111

Closed
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:postmortem-field-count
ConversationCommits (1)ChecksFiles changed
Closed

src: expose BaseObject::kInternalFieldCount in post-mortem metadata#37111
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:postmortem-field-count

Conversation

joyeecheung commented Jan 28, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

So that the debugger does not have to hard-code the number of
internal fields of BaseObjects.

Refs: #36943

src: expose BaseObject::kInternalFieldCount in post-mortem metadata
91f1c3b 
So that the debugger does not have to hard-code the number of
internal fields of BaseObjects.
nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 28, 2021
joyeecheung mentioned this pull request Jan 28, 2021
Closed

nodejs-github-bot commented Jan 28, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35800/

nodejs-github-bot commented Jan 31, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35832/

joyeecheung commented Feb 2, 2021

Copy link
Copy Markdown
Member Author

Landed in 638fb48

joyeecheung closed this Feb 2, 2021
joyeecheung added a commit that referenced this pull request Feb 2, 2021
src: expose BaseObject::kInternalFieldCount in post-mortem metadata
638fb48 
So that the debugger does not have to hard-code the number of
internal fields of BaseObjects.

PR-URL: #37111
Refs: #36943
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Feb 2, 2021
src: expose BaseObject::kInternalFieldCount in post-mortem metadata
a26dfb3 
So that the debugger does not have to hard-code the number of
internal fields of BaseObjects.

PR-URL: #37111
Refs: #36943
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Feb 2, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
src: expose BaseObject::kInternalFieldCount in post-mortem metadata
1ecdb66 
So that the debugger does not have to hard-code the number of
internal fields of BaseObjects.

PR-URL: #37111
Refs: #36943
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request May 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL