FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: put (de)serialization code into node_snapshotable.h/cc by joyeecheung · Pull Request #37114 · nodejs/node · GitHub

/ node Public

src: put (de)serialization code into node_snapshotable.h/cc - #37114

Closed
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:split-serializable
ConversationCommits (1)ChecksFiles changed
Closed

src: put (de)serialization code into node_snapshotable.h/cc#37114
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:split-serializable

Conversation

joyeecheung commented Jan 28, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

So that it's easier to find the corresponding code.

Refs: #36943
Refs: #35711

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jan 28, 2021
joyeecheung changed the title src: put (de)serialization code into node_snapshottable.h/cc src: put (de)serialization code into node_snapshotable.h/cc Jan 28, 2021
src: put (de)serialization code into node_snapshotable.h/cc
5590b7b 
So that it's easier to find the corresponding code.
joyeecheung mentioned this pull request Jan 28, 2021
Closed

nodejs-github-bot commented Jan 28, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35803/

joyeecheung added a commit that referenced this pull request Feb 5, 2021
src: put (de)serialization code into node_snapshotable.h/cc
2e769a9 
So that it's easier to find the corresponding code.

PR-URL: #37114
Refs: #36943
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

joyeecheung commented Feb 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

Landed in 2e769a9

joyeecheung closed this Feb 5, 2021
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
src: put (de)serialization code into node_snapshotable.h/cc
337b4e7 
So that it's easier to find the corresponding code.

PR-URL: #37114
Refs: #36943
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
This was referenced Feb 16, 2021
Closed
Merged
richardlau mentioned this pull request Jul 19, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

juanarbol juanarbol approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL