FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fs: allow passing negative zero fd by RaisinTen · Pull Request #37123 · nodejs/node · GitHub

/ node Public

fs: allow passing negative zero fd - #37123

Merged
Trott merged 1 commit into
nodejs:masterfrom
RaisinTen:fs/fix-negative-zero-for-fd
Feb 6, 2021
ConversationCommits (1)ChecksFiles changed
Merged

fs: allow passing negative zero fd#37123
Trott merged 1 commit into
nodejs:masterfrom
RaisinTen:fs/fix-negative-zero-for-fd

Conversation

RaisinTen commented Jan 29, 2021

Copy link
Copy Markdown
Member

Fixes: #37122

nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Jan 29, 2021

nodejs-github-bot commented Jan 29, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35807/

aduh95 approved these changes Jan 29, 2021
View reviewed changes
Comment thread test/parallel/test-fs-stat.js Outdated

RaisinTen commented Jan 29, 2021

Copy link
Copy Markdown
Member Author

@aduh95 do you know why the mac os run got cancelled here: eac8f2f?

aduh95 commented Jan 29, 2021

Copy link
Copy Markdown
Contributor

@aduh95 do you know why the mac os run got cancelled here: eac8f2f?

I canceled it – when a lot of changes are being pushed at the same time to the repo, we are hitting GH Actions limitations and sometimes it takes hours for all the CI to complete. So I try to cancel jobs on commits which has more recents commits on the same PR as we don't need those anyway.

nodejs-github-bot commented Jan 29, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35808/

aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 29, 2021
mscdex reviewed Jan 29, 2021
View reviewed changes
Comment thread lib/internal/fs/utils.js Outdated
aduh95 mentioned this pull request Jan 29, 2021
Closed
juanarbol previously requested changes Jan 30, 2021
View reviewed changes
Comment thread lib/internal/fs/utils.js Outdated
aduh95 removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 30, 2021

nodejs-github-bot commented Feb 1, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35872/

aduh95 dismissed juanarbol’s stale review February 1, 2021 22:10

He confirmed his suggestion is not a blocker in a comment above.

aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 1, 2021

nodejs-github-bot commented Feb 2, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35883/

nodejs-github-bot commented Feb 5, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35964/

RaisinTen force-pushed the fs/fix-negative-zero-for-fd branch from 0e9d2b8 to 8dfb8f5 Compare February 5, 2021 16:06

RaisinTen commented Feb 5, 2021

Copy link
Copy Markdown
Member Author

Rebased to resolve the conflicts. Restarting the CI.

nodejs-github-bot commented Feb 5, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35965/

nodejs-github-bot commented Feb 5, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35967/

fs: allow passing negative zero fd
6b8b165 
Fixes: nodejs#37122

PR-URL: nodejs#37123
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott force-pushed the fs/fix-negative-zero-for-fd branch from 016550c to 6b8b165 Compare February 6, 2021 13:10
Trott merged commit 6b8b165 into nodejs:master Feb 6, 2021

Trott commented Feb 6, 2021

Copy link
Copy Markdown
Member

Landed in 6b8b165

RaisinTen deleted the fs/fix-negative-zero-for-fd branch February 6, 2021 13:37
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
fs: allow passing negative zero fd
c302450 
Fixes: #37122

PR-URL: #37123
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Feb 16, 2021
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 approved these changes
juanarbol juanarbol left review comments
Trott Trott approved these changes
Lxxyx Lxxyx approved these changes
+1 more reviewer
mscdex mscdex left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fs: error when fd = -0

8 participants

Back | FazBrowse Home | New Git URL