FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Updated CONTRIBUTING.md by NegiAkash890 · Pull Request #37138 · nodejs/node · GitHub

/ node Public

Updated CONTRIBUTING.md - #37138

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
NegiAkash890:patch-1
Feb 1, 2021
Merged

Updated CONTRIBUTING.md#37138
aduh95 merged 1 commit into
nodejs:masterfrom
NegiAkash890:patch-1

Conversation

Copy link
Copy Markdown
Contributor

Fixed the bullets Points and added indentation for better readability .

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 30, 2021

Copy link
Copy Markdown
Contributor

@NegiAkash890 - thanks for your first-time contribution to Node.js . I suggest , instead of removing bullets , can you replace alphabetical order of points with bullets points for better readability?

targos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This corresponds to the format at https://developercertificate.org/

PoojaDurgad added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 1, 2021
This corresponds to the format at https://developercertificate.org/.

PR-URL: nodejs#37138
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>

aduh95 commented Feb 1, 2021

Copy link
Copy Markdown
Contributor

Landed in b5f5c46

aduh95 merged commit b5f5c46 into nodejs:master Feb 1, 2021
targos pushed a commit that referenced this pull request Feb 2, 2021
This corresponds to the format at https://developercertificate.org/.

PR-URL: #37138
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos mentioned this pull request Feb 2, 2021
targos pushed a commit that referenced this pull request May 1, 2021
This corresponds to the format at https://developercertificate.org/.

PR-URL: #37138
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
danielleadams mentioned this pull request May 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL