vm: add import assertion support - #37176
Merged
devsnek merged 1 commit intoMar 23, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
devsnek
marked this pull request as draft
February 1, 2021 22:22
cjihrig
reviewed
Feb 1, 2021
Comment thread
doc/api/vm.md
Outdated
devsnek
force-pushed
the
vm-import-assertion
branch
from
91e224b to
a290d09
Compare
February 1, 2021 22:29
addaleax
approved these changes
Feb 4, 2021
addaleax
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM (with a comment to avoid crashing in cases of prototype pollution addressed)
Sorry, something went wrong.
Comment thread
src/module_wrap.cc
Outdated
devsnek
force-pushed
the
vm-import-assertion
branch
from
a290d09 to
4c489f2
Compare
February 5, 2021 06:36
devsnek
force-pushed
the
vm-import-assertion
branch
from
4c489f2 to
d6b0b14
Compare
March 23, 2021 00:16
devsnek
marked this pull request as ready for review
March 23, 2021 00:21
devsnek
force-pushed
the
vm-import-assertion
branch
from
d6b0b14 to
84cdb17
Compare
March 23, 2021 00:22
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
approved these changes
Mar 23, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
PR-URL: nodejs#37176 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
devsnek
force-pushed
the
vm-import-assertion
branch
from
84cdb17 to
26eed3e
Compare
March 23, 2021 16:04
ruyadorno
pushed a commit
that referenced
this pull request
Mar 24, 2021
PR-URL: #37176 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Copy link
Copy Markdown
Member
|
hi @devsnek this commit is breaking make cctest in v15.x-staging - should it be backported to v15.x? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@ruyadorno nope! its stuck to the v8 version in master 😄 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a draft until our V8 is new enough to support this.