| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
@aduh95 thanks, (I thought author-ready implies CI started though?) |
Sorry, something went wrong.
For doc-only changes, GH Actions are enough to land. node/doc/guides/collaborator-guide.md Line 217 in 9cf2341 |
Sorry, something went wrong.
|
Good to know, thanks 🙏 |
Sorry, something went wrong.
|
Apparently this is also fine to fast-track according to:
So 👍 to fast track if you think this is fine to fast-track :] |
Sorry, something went wrong.
|
nit: then fulfills feels a little abrupt in these sentences. Should we prepend an and or a , to make it sound better? |
Sorry, something went wrong.
|
@RaisinTen I don't mind making a follow up PR auditing the documentation further - I think certain ways we phrase things isn't really super helpful: For example stuff like #### `filehandle.chown(uid, gid)`
<!-- YAML
added: v10.0.0
-->
* `uid` {integer}
* `gid` {integer}
* Returns: {Promise}
Changes the ownership of the file then fulfills the `Promise` with no arguments
upon success.
Probably should be: #### `filehandle.chown(uid, gid)`
<!-- YAML
added: v10.0.0
-->
* `uid` {integer} The file's new owner's user id.
* `gid` {integer} The file's new group's group id.
* Returns: {Promise} Fulfills with `undefined` when the operation has completed.
Changes the ownership of the given file. A wrapper for chown(2). |
Sorry, something went wrong.
|
If I make such a PR would you be up for reviewing? |
Sorry, something went wrong.
PR-URL: #37181 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
|
@benjamingr that looks much better. Sure, I will. :) |
Sorry, something went wrong.
PR-URL: #37181 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #37181 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
| Back | FazBrowse Home | New Git URL |
This is kind of a nit but:
A promise is: