FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix 404 links in module.md by aduh95 · Pull Request #37202 · nodejs/node · GitHub

/ node Public

doc: fix 404 links in module.md - #37202

Closed
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:module.md-introduction
Closed

doc: fix 404 links in module.md#37202
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:module.md-introduction

Conversation

aduh95 commented Feb 3, 2021

Copy link
Copy Markdown
Contributor

Currently the docs show links for all the available docs it has:

But the page is actually available only on v12 and v14+.

nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Feb 3, 2021
Lxxyx added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 3, 2021

Lxxyx commented Feb 3, 2021

Copy link
Copy Markdown
Member

fast track?

Lxxyx commented Feb 3, 2021

Copy link
Copy Markdown
Member

Cancel Ci running for macOS because it is always pending

Lxxyx commented Feb 3, 2021

Copy link
Copy Markdown
Member

Landed in 3b40893

Lxxyx closed this Feb 3, 2021
Lxxyx pushed a commit that referenced this pull request Feb 3, 2021
PR-URL: #37202
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
aduh95 deleted the module.md-introduction branch February 3, 2021 13:08
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
PR-URL: #37202
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
This was referenced Feb 16, 2021
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #37202
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams mentioned this pull request May 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. module Issues and PRs related to the module subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL