test: rename n-api to node-api - #37217
Merged
Trott merged 1 commit intoFeb 6, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Closed
mhdawson
approved these changes
Feb 3, 2021
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
BethGriggs
approved these changes
Feb 4, 2021
marsonya
approved these changes
Feb 4, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
approved these changes
Feb 6, 2021
This renames the macros used in the tests from `NAPI_*` to `NODE_API_*`. PR-URL: nodejs#37217 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
force-pushed
the
rename-napi-test
branch
from
7c65756 to
4b7f23f
Compare
February 6, 2021 13:04
danielleadams
pushed a commit
that referenced
this pull request
Feb 16, 2021
This renames the macros used in the tests from `NAPI_*` to `NODE_API_*`. PR-URL: #37217 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Copy link
Copy Markdown
Contributor
|
@gabrielschulhof do you mind opening a 14.x backport PR? There are failing tests when these changes are pulled in. |
Sorry, something went wrong.
This was referenced Jul 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames the macros used in the tests from NAPI_* to
NODE_API_*.