FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add thealphanerd to collaborators by MylesBorins · Pull Request #3723 · nodejs/node · GitHub

/ node Public

doc: add thealphanerd to collaborators - #3723

Closed
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:add-thealphanerd
ConversationCommits (1)ChecksFiles changed
Closed

doc: add thealphanerd to collaborators#3723
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:add-thealphanerd

Conversation

MylesBorins commented Nov 9, 2015

Copy link
Copy Markdown
Contributor

No description provided.

cjihrig commented Nov 9, 2015

Copy link
Copy Markdown
Contributor

LGTM

evanlucas commented Nov 9, 2015

Copy link
Copy Markdown
Contributor

LGTM. yay

Trott commented Nov 9, 2015

Copy link
Copy Markdown
Member

Trott commented Nov 9, 2015

Copy link
Copy Markdown
Member

Er, uh, actually, aren't the collaborators listed in alphabetical order by GitHub username?

evanlucas commented Nov 9, 2015

Copy link
Copy Markdown
Contributor

good point

MylesBorins commented Nov 9, 2015

Copy link
Copy Markdown
Contributor Author

fixed

MylesBorins commented Nov 9, 2015

Copy link
Copy Markdown
Contributor Author

Can I get another round of LGTM 😄

evanlucas commented Nov 9, 2015

Copy link
Copy Markdown
Contributor

LGTM

Fishrock123 added the doc Issues and PRs related to the documentations. label Nov 9, 2015

Trott commented Nov 9, 2015

Copy link
Copy Markdown
Member

LGTM

1 similar comment

saghul commented Nov 9, 2015

Copy link
Copy Markdown
Member

LGTM

MylesBorins commented Nov 9, 2015

Copy link
Copy Markdown
Contributor Author

Landed in 7b89a3d

MylesBorins pushed a commit that referenced this pull request Nov 9, 2015
doc: add thealphanerd to collaborators
7b89a3d 
PR-URL: #3723
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
MylesBorins closed this Nov 9, 2015
Fishrock123 mentioned this pull request Nov 9, 2015
Closed
MylesBorins pushed a commit that referenced this pull request Nov 10, 2015
doc: add thealphanerd to collaborators
e5b9109 
PR-URL: #3723
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Fishrock123 mentioned this pull request Nov 10, 2015
Closed
Fishrock123 mentioned this pull request Nov 11, 2015
Merged
MylesBorins pushed a commit that referenced this pull request Nov 17, 2015
doc: add thealphanerd to collaborators
64e6d06 
PR-URL: #3723
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

MylesBorins commented Nov 17, 2015

Copy link
Copy Markdown
Contributor Author

landed in v4.x-staging in 64e6d06

rvagg mentioned this pull request Nov 17, 2015
Closed
MylesBorins pushed a commit that referenced this pull request Dec 4, 2015
doc: add thealphanerd to collaborators
d27f440 
PR-URL: #3723
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
jasnell mentioned this pull request Dec 17, 2015
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2015
doc: add thealphanerd to collaborators
5232512 
PR-URL: #3723
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 23, 2015
doc: add thealphanerd to collaborators
7e98c9c 
PR-URL: #3723
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL