FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add romankl to collaborators by r-52 · Pull Request #3725 · nodejs/node · GitHub

/ node Public

doc: add romankl to collaborators - #3725

Closed
r-52 wants to merge 1 commit into
nodejs:masterfrom
r-52:add-to-collab
ConversationCommits (1)ChecksFiles changed
Closed

doc: add romankl to collaborators#3725
r-52 wants to merge 1 commit into
nodejs:masterfrom
r-52:add-to-collab

Conversation

r-52 commented Nov 9, 2015

Copy link
Copy Markdown
Contributor

No description provided.

MylesBorins commented Nov 9, 2015

Copy link
Copy Markdown
Contributor

LGTM

3 similar comments

evanlucas commented Nov 9, 2015

Copy link
Copy Markdown
Contributor

LGTM

Fishrock123 commented Nov 9, 2015

Copy link
Copy Markdown
Contributor

LGTM

Trott commented Nov 9, 2015

Copy link
Copy Markdown
Member

LGTM

Fishrock123 commented Nov 9, 2015

Copy link
Copy Markdown
Contributor

Aside:

@romankl you should probably add yourself to the [mailmap] so that your old git info of Roman Klauke <romankl@users.noreply.github.com> maps to your new email.

Fishrock123 added the doc Issues and PRs related to the documentations. label Nov 9, 2015

saghul commented Nov 9, 2015

Copy link
Copy Markdown
Member

LGTM

Fishrock123 mentioned this pull request Nov 9, 2015
Closed

jbergstroem commented Nov 10, 2015

Copy link
Copy Markdown
Member

🎉 !

thefourtheye commented Nov 10, 2015

Copy link
Copy Markdown
Contributor

This one-liner has a conflict 😮

r-52 commented Nov 10, 2015

Copy link
Copy Markdown
Contributor Author

@Fishrock123 should I include the update in this pr or wait till the next "update AUTHORs" pr ?

jbergstroem commented Nov 10, 2015

Copy link
Copy Markdown
Member

@romankl rebase this branch onto latest master and force push the commit to this branch (to make sure).

Fishrock123 commented Nov 10, 2015

Copy link
Copy Markdown
Contributor

@romankl no that can be done in a separate commit. :)

r-52 added a commit that referenced this pull request Nov 10, 2015
doc: add romankl to collaborators
5235143 
PR-URL: #3725
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

r-52 commented Nov 10, 2015

Copy link
Copy Markdown
Contributor Author

Thank you!! Landed in 5235143

r-52 closed this Nov 10, 2015
r-52 deleted the add-to-collab branch November 10, 2015 18:52
r-52 added a commit that referenced this pull request Nov 11, 2015
doc: add romankl to collaborators
a32d9e3 
PR-URL: #3725
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Fishrock123 mentioned this pull request Nov 11, 2015
Merged
r-52 added a commit that referenced this pull request Nov 17, 2015
doc: add romankl to collaborators
a49dd89 
PR-URL: #3725
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins commented Nov 17, 2015

Copy link
Copy Markdown
Contributor

landed in v4.x-staging in a49dd89

rvagg mentioned this pull request Nov 17, 2015
Closed
r-52 added a commit that referenced this pull request Dec 4, 2015
doc: add romankl to collaborators
a926659 
PR-URL: #3725
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
jasnell mentioned this pull request Dec 17, 2015
Closed
r-52 added a commit that referenced this pull request Dec 17, 2015
doc: add romankl to collaborators
7b5e457 
PR-URL: #3725
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
r-52 added a commit that referenced this pull request Dec 23, 2015
doc: add romankl to collaborators
90344fc 
PR-URL: #3725
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL