doc: rename N-API to Node-API - #37259
Closed
gabrielschulhof wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
richardlau
reviewed
Feb 7, 2021
Comment thread
tools/lint-md.js
Outdated
Trott
approved these changes
Feb 8, 2021
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 8, 2021
This is a prerequisite for nodejs#37259. PR-URL: nodejs#37270 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Trott
force-pushed
the
rename-n-api-doc
branch
from
5840edb to
ac99f0c
Compare
February 8, 2021 12:31
gireeshpunathil
approved these changes
Feb 8, 2021
gabrielschulhof
force-pushed
the
rename-n-api-doc
branch
from
90e8550 to
ac99f0c
Compare
February 8, 2021 17:07
gabrielschulhof
pushed a commit
that referenced
this pull request
Feb 8, 2021
Refs: nodejs/abi-stable-node#420 PR-URL: #37259 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
ExE-Boss
suggested changes
Feb 9, 2021
Comment thread
doc/api/n-api.md
| handling section [Error handling][]. | ||
|
|
||
| The N-API is a C API that ensures ABI stability across Node.js versions | ||
| Node-API-API is a C API that ensures ABI stability across Node.js versions |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Suggested change
| Node-API-API is a C API that ensures ABI stability across Node.js versions | |
| Node-API is a C API that ensures ABI stability across Node.js versions |
Sorry, something went wrong.
danielleadams
pushed a commit
that referenced
this pull request
Feb 16, 2021
Refs: nodejs/abi-stable-node#420 PR-URL: #37259 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Refs: nodejs/abi-stable-node#420 PR-URL: #37259 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.