FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fixed typos in doc/api/deprecations.md and doc/api/diagnostics_channel.md by marsonya · Pull Request #37282 · nodejs/node · GitHub

/ node Public

doc: fixed typos in doc/api/deprecations.md and doc/api/diagnostics_channel.md - #37282

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
marsonya:doc-type-fix-3
Feb 13, 2021
ConversationCommits (1)ChecksFiles changed
Merged

doc: fixed typos in doc/api/deprecations.md and doc/api/diagnostics_channel.md#37282
aduh95 merged 1 commit into
nodejs:masterfrom
marsonya:doc-type-fix-3

Conversation

marsonya commented Feb 8, 2021

Copy link
Copy Markdown
Member

in doc/api/deprecations.md -> 'ambiguity' was spelled 'ambigiuty'
in doc/api/diagnostics_channel.md -> 'sensitive' was spelled 'senstive' (twice)

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 8, 2021

Trott commented Feb 8, 2021

Copy link
Copy Markdown
Member

It's a small thing, and you don't have to worry about it here because it can be fixed (or not) on landing, but our commit messages should use an imperative verb, so "doc: fix typo in foo.md" rather than "doc: fixed typo in foo.md". Normally, I wouldn't say anything, but because it looks like there may be a lot of these, I thought I'd mention it.

Thanks for the PRs!

mhdawson approved these changes Feb 8, 2021
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

ItzLevvie approved these changes Feb 8, 2021
View reviewed changes

ItzLevvie left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

marsonya commented Feb 9, 2021

Copy link
Copy Markdown
Member Author

It's a small thing, and you don't have to worry about it here because it can be fixed (or not) on landing, but our commit messages should use an imperative verb, so "doc: fix typo in foo.md" rather than "doc: fixed typo in foo.md". Normally, I wouldn't say anything, but because it looks like there may be a lot of these, I thought I'd mention it.

Thanks for the PRs!

Thank you for bringing it up. I will keep it in mind.

RaisinTen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 9, 2021
doc: fix typo in deprecations.md
ce4798b 
PR-URL: #37282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
aduh95 merged commit ce4798b into nodejs:master Feb 13, 2021

aduh95 commented Feb 13, 2021

Copy link
Copy Markdown
Contributor

Landed in ce4798b

a498aa6 didn't land as the typo was already fixed in f2c2615

danielleadams pushed a commit that referenced this pull request Feb 16, 2021
doc: fix typo in deprecations.md
85b1476 
PR-URL: #37282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
This was referenced Feb 16, 2021
Closed
Merged
targos pushed a commit that referenced this pull request May 1, 2021
doc: fix typo in deprecations.md
5ade2fd 
PR-URL: #37282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
danielleadams mentioned this pull request May 3, 2021
Merged
wedataintelligence mentioned this pull request Jan 12, 2023
Open
This was referenced Jan 12, 2023
Open
Open
137717unity mentioned this pull request Jan 13, 2023
Open
This was referenced Jan 13, 2023
Open
Open
Open
Open
Open
This was referenced Apr 18, 2023
Open
Open
137717unity mentioned this pull request Apr 18, 2023
Open
wedataintelligence mentioned this pull request Apr 18, 2023
Open
This was referenced Apr 19, 2023
Open
Open
ron-a20 mentioned this pull request Apr 19, 2023
Open
This was referenced Apr 19, 2023
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
lpinca lpinca approved these changes
RaisinTen RaisinTen approved these changes
HarshithaKP HarshithaKP approved these changes
+3 more reviewers
mhdawson mhdawson approved these changes
ItzLevvie ItzLevvie approved these changes
PoojaDurgad PoojaDurgad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL