Does this PR affect any other CJS resolution for oaths with a colon, or only the new self-resolution feature?

Does this PR affect any other CJS resolution for oaths with a colon, or only the new self-resolution feature?

Only CJS self-resolve, if the specifier contains a ::

if (selfResolved) {
  if (StringPrototypeIncludes(request, ':')) {
    throw new ERR_INVALID_MODULE_SPECIFIER(
      request, 'is not a valid package name', parentPath);
  }

It seems really strange that require('foo:bar') would work from outside a package, but not from within it - what's the benefit of only partially limiting use of the colon?

npm's requirements aren't the whole of the ecosystem, and any linked dependency (including in a workspace/monorepo) might never be published, and might use a colon, and might be relying on this feature.

npm's requirements aren't the whole of the ecosystem, and any linked dependency (including in a workspace/monorepo) might never be published, and might use a colon, and might be relying on this feature.

That's a good point, and I guess it's difficult to measure…

It seems really strange that require('foo:bar') would work from outside a package, but not from within it

On that point, on Windows, I believe it currently works only from within, but not from outside.

The ESM loader currently includes the following validation:

If packageName starts with "." or contains "\" or "%", then
Throw an Invalid Module Specifier error.

It might be nice to treat ":" as just another one of the valid characters being checked here for consistency in the ESM loader as well for consistency, even though it doesn't have the same problem as it supports URLs directly.

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

because using a bot to close issues is hostile

Closing as stalled.