FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: fix lint-pr-url message by aduh95 · Pull Request #37304 · nodejs/node · GitHub

/ node Public

tools: fix lint-pr-url message - #37304

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:lint-pr-url
Feb 13, 2021
ConversationCommits (1)ChecksFiles changed
Merged

tools: fix lint-pr-url message#37304
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:lint-pr-url

Conversation

aduh95 commented Feb 10, 2021

Copy link
Copy Markdown
Contributor

actual PR URL message may be a bit confusing, this PR specifies it's talking about the current PR.

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 10, 2021
RaisinTen reviewed Feb 10, 2021
View reviewed changes
Comment thread tools/lint-pr-url.mjs Outdated
Trott approved these changes Feb 10, 2021
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Unrelated to this specific PR, but does this lint job something that doesn't run on backport PRs? I think it might result in false positives if it runs on backport PRs.

aduh95 commented Feb 10, 2021

Copy link
Copy Markdown
Contributor Author

does this lint job something that doesn't run on backport PRs? I think it might result in false positives if it runs on backport PRs.

It does run on backport PRs, and does produce "false positives" warnings. E.G.: https://github.com/nodejs/node/pull/37289/files#diff-71a7964a5c439435680952125e31e9dd4fca3a427982e6db86770fd0fbbfde63R463

I was aware of this when working on this, so I made sure it never produces errors and always completes as green. If people find it too noisy, we can maybe filter out the backport PR somehow.

nodejs-github-bot commented Feb 11, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36058/

aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 11, 2021
tools: fix lint-pr-url message
a803d4a 
PR-URL: nodejs#37304
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

aduh95 commented Feb 13, 2021

Copy link
Copy Markdown
Contributor Author

Landed in a803d4a

aduh95 merged commit a803d4a into nodejs:master Feb 13, 2021
aduh95 deleted the lint-pr-url branch February 13, 2021 17:09
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
tools: fix lint-pr-url message
a483c28 
PR-URL: #37304
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Feb 16, 2021
Closed
Merged
targos pushed a commit that referenced this pull request May 1, 2021
tools: fix lint-pr-url message
af8b385 
PR-URL: #37304
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams mentioned this pull request May 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

RaisinTen RaisinTen approved these changes
Trott Trott approved these changes
lpinca lpinca approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL