FazBrowse GitHub Viewer | Trending | | Home

Tools: [Download Repo ZIP] [Original HTTPS Page]

src: fix more MSVC warnings by targos · Pull Request #37334 · nodejs/node · GitHub

src: fix more MSVC warnings - #37334

Closed

targos wants to merge 4 commits into

nodejs:masterfrom

targos:win-c4244-2

targos commented Feb 12, 2021 •
edited
Loading

Copy link Copy Markdown

Member

commit c0a9289

src: avoid implicit type conversions (take 2)

This fixes more C4244 MSVC warnings in the code base.

Refs: https://github.com/nodejs/node/pull/37149

commit 6e89d73

src: disable unfixable MSVC warnings

The following warnings are disabled:
- C4065 in node_revert.h: there are no security reversions on the master
  branch.
- C4003 in base64-inl.h: a macro is used four times, only once without
  parameters.

commit 4f94dbc

src: fix ETW_WRITE_EMPTY_EVENT macro

A comment was written before the last line, hiding a check.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Feb 12, 2021

targos added windows Issues and PRs related to the Windows platform. lib / src Issues and PRs related to general changes in the lib or src directory. and removed lib / src Issues and PRs related to general changes in the lib or src directory. labels Feb 12, 2021

targos added 2 commits February 12, 2021 20:57

src: avoid implicit type conversions (take 2)

c0a9289

This fixes more C4244 MSVC warnings in the code base.

Refs: nodejs#37149

src: disable unfixable MSVC warnings

6e89d73

The following warnings are disabled:
- C4065 in node_revert.h: there are no security reversions on the master
  branch.
- C4003 in base64-inl.h: a macro is used four times, only once without
  parameters.

targos force-pushed the win-c4244-2 branch from d9eaeb7 to e9bd391 Compare February 12, 2021 20:00

src: fix ETW_WRITE_EMPTY_EVENT macro

4f94dbc

A comment was written before the last line, hiding a check.

targos force-pushed the win-c4244-2 branch from e9bd391 to 4f94dbc Compare February 12, 2021 20:15

targos commented Feb 12, 2021

Copy link Copy Markdown

Member Author

I ended up with 4f94dbc to fix the lint error. Open to a better alternative...

This comment has been minimized.

Sign in to view

fixup! src: fix ETW_WRITE_EMPTY_EVENT macro

8d9cac8

nodejs-github-bot commented Feb 12, 2021

Copy link Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36080/

nodejs-github-bot commented Feb 13, 2021

Copy link Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36095/

jasnell approved these changes Feb 14, 2021

View reviewed changes

targos commented Feb 16, 2021

Copy link Copy Markdown

Member Author

Anyone else wants to review?

targos added a commit that referenced this pull request Feb 20, 2021

src: avoid implicit type conversions (take 2)

d1f1fcf

This fixes more C4244 MSVC warnings in the code base.

Refs: #37149

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request Feb 20, 2021

src: disable unfixable MSVC warnings

5454c12

The following warnings are disabled:
- C4065 in node_revert.h: there are no security reversions on the master
  branch.
- C4003 in base64-inl.h: a macro is used four times, only once without
  parameters.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request Feb 20, 2021

src: fix ETW_WRITE_EMPTY_EVENT macro

a142842

A comment was written before the last line, hiding a check.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>

targos commented Feb 20, 2021

Copy link Copy Markdown

Member Author

Landed in 5421e15...a142842

targos closed this Feb 20, 2021

targos deleted the win-c4244-2 branch February 20, 2021 09:54

targos added a commit that referenced this pull request Feb 28, 2021

src: avoid implicit type conversions (take 2)

c75f5f3

This fixes more C4244 MSVC warnings in the code base.

Refs: #37149

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request Feb 28, 2021

src: disable unfixable MSVC warnings

96bcd52

The following warnings are disabled:
- C4065 in node_revert.h: there are no security reversions on the master
  branch.
- C4003 in base64-inl.h: a macro is used four times, only once without
  parameters.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request Feb 28, 2021

src: fix ETW_WRITE_EMPTY_EVENT macro

5ea2ed6

A comment was written before the last line, hiding a check.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>

targos mentioned this pull request Mar 2, 2021

v15.11.0 release proposal #37569

Merged

targos added a commit that referenced this pull request May 27, 2021

src: avoid implicit type conversions (take 2)

e622457

This fixes more C4244 MSVC warnings in the code base.

Refs: #37149

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request May 27, 2021

src: disable unfixable MSVC warnings

47f6a3e

The following warnings are disabled:
- C4065 in node_revert.h: there are no security reversions on the master
  branch.
- C4003 in base64-inl.h: a macro is used four times, only once without
  parameters.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request May 27, 2021

src: fix ETW_WRITE_EMPTY_EVENT macro

ebbbbe4

A comment was written before the last line, hiding a check.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request May 30, 2021

src: avoid implicit type conversions (take 2)

b6b4a08

This fixes more C4244 MSVC warnings in the code base.

Refs: #37149

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request May 30, 2021

src: disable unfixable MSVC warnings

52a5705

The following warnings are disabled:
- C4065 in node_revert.h: there are no security reversions on the master
  branch.
- C4003 in base64-inl.h: a macro is used four times, only once without
  parameters.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request May 30, 2021

src: fix ETW_WRITE_EMPTY_EVENT macro

e23f625

A comment was written before the last line, hiding a check.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request Jun 5, 2021

src: avoid implicit type conversions (take 2)

babea9c

This fixes more C4244 MSVC warnings in the code base.

Refs: #37149

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request Jun 5, 2021

src: disable unfixable MSVC warnings

2e527fb

The following warnings are disabled:
- C4065 in node_revert.h: there are no security reversions on the master
  branch.
- C4003 in base64-inl.h: a macro is used four times, only once without
  parameters.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request Jun 5, 2021

src: fix ETW_WRITE_EMPTY_EVENT macro

6c1ea69

A comment was written before the last line, hiding a check.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>

targos mentioned this pull request Jun 6, 2021

v14.17.1 release proposal #38948

Merged

targos added a commit that referenced this pull request Jun 11, 2021

src: avoid implicit type conversions (take 2)

38afa3f

This fixes more C4244 MSVC warnings in the code base.

Refs: #37149

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request Jun 11, 2021

src: disable unfixable MSVC warnings

6b1052d

The following warnings are disabled:
- C4065 in node_revert.h: there are no security reversions on the master
  branch.
- C4003 in base64-inl.h: a macro is used four times, only once without
  parameters.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request Jun 11, 2021

src: fix ETW_WRITE_EMPTY_EVENT macro

f5541dd

A comment was written before the last line, hiding a check.

PR-URL: #37334
Reviewed-By: James M Snell <jasnell@gmail.com>

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters

Show hidden characters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. windows Issues and PRs related to the Windows platform.

Projects

Milestone

No milestone

Back | FazBrowse Home | New Git URL