test: clarify usage of tmpdir.refresh() - #37383
Merged
aduh95 merged 1 commit intoFeb 22, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Trott
reviewed
Feb 17, 2021
Comment thread
test/common/README.md
Outdated
Trott
approved these changes
Feb 18, 2021
Lxxyx
approved these changes
Feb 18, 2021
jasnell
approved these changes
Feb 18, 2021
lpinca
approved these changes
Feb 18, 2021
gireeshpunathil
approved these changes
Feb 19, 2021
This emphasizes that `tmpdir.refresh()` must be called only once in each test file when needed. PR-URL: nodejs#37383 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
aduh95
force-pushed
the
test,doc/clarify-usage-of-tmpdir-refresh
branch
from
1f6ae87 to
127f47e
Compare
February 22, 2021 11:23
targos
pushed a commit
that referenced
this pull request
Feb 28, 2021
This emphasizes that `tmpdir.refresh()` must be called only once in each test file when needed. PR-URL: #37383 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
This emphasizes that `tmpdir.refresh()` must be called only once in each test file when needed. PR-URL: #37383 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This emphasizes that tmpdir.refresh() must be called only once in each
test file when needed.