FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: incorrect timers-promisified test case by ttzztztz · Pull Request #37425 · nodejs/node · GitHub

/ node Public

fix: incorrect timers-promisified test case - #37425

Closed
ttzztztz wants to merge 10 commits into
nodejs:masterfrom
ttzztztz:fix-test-timers-promisified
ConversationCommits (10)ChecksFiles changed
Closed

fix: incorrect timers-promisified test case#37425
ttzztztz wants to merge 10 commits into
nodejs:masterfrom
ttzztztz:fix-test-timers-promisified

Conversation

ttzztztz commented Feb 18, 2021 •
edited by aduh95
Loading

Copy link
Copy Markdown
Contributor

This test case is incorrect, and it caused too many unit-test failures

https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel7-s390x/25697/testReport/
https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel7-s390x/25708/testReport/
...

You can see it in this page: https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel7-s390x/
This is probably caused by a wrong time-sequence execution order. I'm trying to work on this.

Analysis

  setPromiseTimeout(1).then(() => pre = true);  // L1
  const iterable = setInterval(() => {}, 2); // L2
  //...
  iterator.next().then(...); // L3
  setPromiseTimeout(3).then(() => post = true); // L4

Assume we execute this code at time 0
Time=0, FinishExecute=L1, callback L1 is queued to execute at Time=1
Time=1, FinishExecute=L2, callback L2 is queued to execute at Time=3, 5, 7, ...
Time=2, FinishExecute=L3
Time=11, FinishExecute=L4, callback L3 is queued to execute at Time=14

In this case, this unit test will throw an error 'second interval ran too early', but it is OK.

My solution

First, the timeout is 10, 20, 30 to tolerate the time for code-execution
Second, use the Promise.all to wait for these three promises

I think it would work.

Fixes: #37395

nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 18, 2021

Trott commented Feb 18, 2021

Copy link
Copy Markdown
Member

@benjamingr @Linkgoron @nodejs/timers

Trott commented Feb 18, 2021

Copy link
Copy Markdown
Member

Refs: #37395

Linkgoron commented Feb 18, 2021

Copy link
Copy Markdown
Contributor

In retrospect, I'm not 100% sure that the test is really necessary, as there are already some timing tests.

However, while the test fix looks fine, I'm not sure what the policy is about test performance though, is ~400ms for a test OK?

ttzztztz commented Feb 18, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

In retrospect, I'm not 100% sure that the test is really necessary, as there are already some timing tests.

However, while the test fix looks fine, I'm not sure what the policy is about test performance though, is ~400ms for a test OK?

After looking at other test cases, I found this

const TIMEOUT = common.platformTimeout(100)

The definition of the function platformTimeout is

function platformTimeout(ms) {
  const multipliers = typeof ms === 'bigint' ?
    { two: 2n, four: 4n, seven: 7n } : { two: 2, four: 4, seven: 7 };

  if (process.features.debug)
    ms = multipliers.two * ms;

  if (isAIX)
    return multipliers.two * ms; // Default localhost speed is slower on AIX

  if (process.arch !== 'arm')
    return ms;

  const armv = process.config.variables.arm_version;

  if (armv === '6')
    return multipliers.seven * ms;  // ARMv6

  if (armv === '7')
    return multipliers.two * ms;  // ARMv7

  return ms; // ARMv8+
}

400ms is a long time, I admit. So maybe I can adjust it to common.platformTimeout(...) so that the timeout can be adjusted in different platforms.

aduh95 reviewed Feb 18, 2021
View reviewed changes

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nit

Comment thread test/parallel/test-timers-promisified.js Outdated
Comment thread test/parallel/test-timers-promisified.js Outdated
Comment thread test/parallel/test-timers-promisified.js Outdated
ttzztztz and others added 3 commits February 18, 2021 17:17
Update test/parallel/test-timers-promisified.js
a9737b5 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Update test/parallel/test-timers-promisified.js
9359f9c 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Update test/parallel/test-timers-promisified.js
7509a44 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95 commented Feb 18, 2021

Copy link
Copy Markdown
Contributor

LinuxOne CI is passing: https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel7-s390x/25734/

400ms is a long time, I admit. So maybe I can adjust it to common.platformTimeout(...) so that the timeout can be adjusted in different platforms.

That's sounds like a solid plan! Can you make this change?

ttzztztz commented Feb 19, 2021

Copy link
Copy Markdown
Contributor Author

LinuxOne CI is passing: https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel7-s390x/25734/

400ms is a long time, I admit. So maybe I can adjust it to common.platformTimeout(...) so that the timeout can be adjusted in different platforms.

That's sounds like a solid plan! Can you make this change?

Implemented 51921f73890790322f58c1b263265c39d10c9c01, waiting for the test result.

ttzztztz commented Feb 19, 2021

Copy link
Copy Markdown
Contributor Author

@aduh95 can you run the test-linuxone test for the new changes once again?

nodejs-github-bot commented Feb 19, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36234/

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 19, 2021

aduh95 commented Feb 19, 2021

Copy link
Copy Markdown
Contributor

Fast-track?

Trott reviewed Feb 20, 2021
View reviewed changes
Comment thread test/parallel/test-timers-promisified.js Outdated
}));

setPromiseTimeout(3).then(() => post = true);
const time_unit = common.platformTimeout(50);

Trott Feb 20, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Optional nit: Since the problem we've been seeing is with the test being flaky on a fast machine, I wonder if common.platformTimeout() isn't needed here. It's usually for giving slow machines more time, but the problem we're seeing right now is the other way around--our LinuxONE host is too efficient.

Trott commented Feb 20, 2021

Copy link
Copy Markdown
Member

@nodejs/timers

nodejs-github-bot commented Feb 21, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36271/

Trott mentioned this pull request Feb 25, 2021
Closed
targos pushed a commit to targos/node that referenced this pull request Feb 25, 2021
test: fix incorrect timers-promisified case
63794b4 
PR-URL: nodejs#37425
Fixes: nodejs#37395
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

targos commented Feb 25, 2021

Copy link
Copy Markdown
Member

Landed in 63794b4

targos closed this Feb 25, 2021
RaisinTen mentioned this pull request Feb 25, 2021
Closed
targos pushed a commit that referenced this pull request Feb 28, 2021
test: fix incorrect timers-promisified case
f2aa305 
PR-URL: #37425
Fixes: #37395
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos mentioned this pull request Mar 2, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott left review comments
richardlau richardlau approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

investigate flaky test-timers-promisified

7 participants

Back | FazBrowse Home | New Git URL