test: remove FLAKY for test-http2-compat-client-upload-reject - #37462
Closed
Trott wants to merge 1 commit into
Closed
test: remove FLAKY for test-http2-compat-client-upload-reject#37462Trott wants to merge 1 commit into
Trott wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
approved these changes
Feb 21, 2021
lpinca
approved these changes
Feb 21, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
marsonya
approved these changes
Feb 22, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
As far as I know, this test hasn't failed since around the time it was first reported in 2019. Closes: nodejs#30847
Trott
force-pushed
the
test-http2-flaky
branch
from
b5238a8 to
72ff2b2
Compare
February 23, 2021 01:17
mhdawson
approved these changes
Feb 23, 2021
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
jasnell
approved these changes
Feb 23, 2021
jasnell
pushed a commit
that referenced
this pull request
Feb 23, 2021
As far as I know, this test hasn't failed since around the time it was first reported in 2019. Closes: #30847 PR-URL: #37462 Fixes: #30847 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 28, 2021
As far as I know, this test hasn't failed since around the time it was first reported in 2019. Closes: #30847 PR-URL: #37462 Fixes: #30847 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
As far as I know, this test hasn't failed since around the time it was first reported in 2019. Closes: #30847 PR-URL: #37462 Fixes: #30847 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I know, this test hasn't failed since around the time it was
first reported in 2019.
Closes: #30847