FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: document how to register external bindings for snapshot by joyeecheung · Pull Request #37463 · nodejs/node · GitHub

/ node Public

doc: document how to register external bindings for snapshot - #37463

Closed
joyeecheung wants to merge 3 commits into
nodejs:masterfrom
joyeecheung:external-binding-doc
ConversationCommits (3)ChecksFiles changed
Closed

doc: document how to register external bindings for snapshot#37463
joyeecheung wants to merge 3 commits into
nodejs:masterfrom
joyeecheung:external-binding-doc

Conversation

joyeecheung commented Feb 21, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Refs: #35711

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 21, 2021
juanarbol approved these changes Feb 21, 2021
View reviewed changes

juanarbol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

<3

juanarbol added the doc Issues and PRs related to the documentations. label Feb 21, 2021
jasnell reviewed Feb 22, 2021
View reviewed changes
Comment thread src/README.md
} // namespace util
} // namespace node

NODE_MODULE_EXTERNAL_REFERENCE(util, node::util::RegisterExternalReferences)

jasnell Feb 22, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Might want to also point out that util needs to be listed in the node_external_reference.h EXTERNAL_REFERENCE_BINDING_LIST_BASE macro

marsonya requested changes Feb 24, 2021
View reviewed changes
Comment thread src/README.md Outdated
fixup! doc: document how to register external bindings for snapshot
b996af7 
Co-authored-by: akhil marsonya <16393876+marsonya@users.noreply.github.com>
joyeecheung added a commit that referenced this pull request Mar 1, 2021
doc: document how to register external bindings for snapshot
7c63bc6 
PR-URL: #37463
Refs: #35711
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

joyeecheung commented Mar 1, 2021

Copy link
Copy Markdown
Member Author

Landed in 7c63bc6

joyeecheung closed this Mar 1, 2021
targos pushed a commit that referenced this pull request Mar 2, 2021
doc: document how to register external bindings for snapshot
cbfc6b1 
PR-URL: #37463
Refs: #35711
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Mar 2, 2021
Merged
targos pushed a commit that referenced this pull request May 27, 2021
doc: document how to register external bindings for snapshot
640e6be 
PR-URL: #37463
Refs: #35711
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request May 30, 2021
doc: document how to register external bindings for snapshot
de77c3e 
PR-URL: #37463
Refs: #35711
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
doc: document how to register external bindings for snapshot
21f321c 
PR-URL: #37463
Refs: #35711
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
doc: document how to register external bindings for snapshot
bc6ea63 
PR-URL: #37463
Refs: #35711
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
marsonya marsonya approved these changes
juanarbol juanarbol approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL