FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: document the NO_COLOR and FORCE_COLOR env vars by jasnell · Pull Request #37477 · nodejs/node · GitHub

/ node Public

doc: document the NO_COLOR and FORCE_COLOR env vars - #37477

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:no_color_force-color
ConversationCommits (1)ChecksFiles changed
Closed

doc: document the NO_COLOR and FORCE_COLOR env vars#37477
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:no_color_force-color

Conversation

jasnell commented Feb 22, 2021

Copy link
Copy Markdown
Member

Signed-off-by: James M Snell jasnell@gmail.com
Fixes: #37404

jasnell mentioned this pull request Feb 22, 2021
Closed
Trott reviewed Feb 22, 2021
View reviewed changes
Comment thread doc/api/cli.md Outdated
Trott reviewed Feb 22, 2021
View reviewed changes
Comment thread doc/api/cli.md Outdated
Trott reviewed Feb 22, 2021
View reviewed changes
Comment thread doc/api/cli.md Outdated

Trott commented Feb 22, 2021

Copy link
Copy Markdown
Member

These entries need to be duplicated into doc/node.1 so that they show up in the man page.

lpinca approved these changes Feb 22, 2021
View reviewed changes

lpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with @Trott's nits addressed.

Trott reviewed Feb 23, 2021
View reviewed changes
Comment thread doc/api/cli.md Outdated
Trott previously requested changes Feb 23, 2021
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me, but leaving a "Request changes" until the entries are in doc/node.1 as well. Feel free to dismiss this review once that's happened.

jasnell force-pushed the no_color_force-color branch from e9a759f to 1d4d8b2 Compare February 23, 2021 15:22
jasnell added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. labels Feb 23, 2021
BridgeAR reviewed Feb 23, 2021
View reviewed changes

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM % comments.

Comment thread doc/api/cli.md Outdated
Comment thread doc/api/cli.md Outdated
BridgeAR removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 23, 2021
jasnell force-pushed the no_color_force-color branch from 1d4d8b2 to ff754fe Compare February 25, 2021 22:38
doc: document the NO_COLOR and FORCE_COLOR env vars
95b0fe7 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: nodejs#37404
jasnell force-pushed the no_color_force-color branch from ff754fe to 95b0fe7 Compare February 25, 2021 22:43

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Feb 26, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36378/

nodejs-github-bot commented Feb 26, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36380/

jasnell commented Feb 26, 2021

Copy link
Copy Markdown
Member Author

Landed in fc6d8f4

jasnell closed this Feb 26, 2021
jasnell added a commit that referenced this pull request Feb 26, 2021
doc: document the NO_COLOR and FORCE_COLOR env vars
fc6d8f4 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #37404

PR-URL: #37477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
sthagen mentioned this pull request Feb 27, 2021
Merged
targos pushed a commit that referenced this pull request Feb 28, 2021
doc: document the NO_COLOR and FORCE_COLOR env vars
3b7cb75 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #37404

PR-URL: #37477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request Mar 2, 2021
Merged
Alhadis reviewed Mar 5, 2021
View reviewed changes
Comment thread doc/node.1
Comment on lines +535 to +536
.Ar 1
,

Alhadis Mar 5, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Most mdoc(7) macros allow authors to include trailing punctuation as a separate (final) argument:

.Ar 1 ,

See the "Delimiters" section of mdoc(7) for more info on this feature.

targos pushed a commit that referenced this pull request May 27, 2021
doc: document the NO_COLOR and FORCE_COLOR env vars
7a67a90 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #37404

PR-URL: #37477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request May 30, 2021
doc: document the NO_COLOR and FORCE_COLOR env vars
5cf0b58 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #37404

PR-URL: #37477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
doc: document the NO_COLOR and FORCE_COLOR env vars
f0daaec 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #37404

PR-URL: #37477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
doc: document the NO_COLOR and FORCE_COLOR env vars
2168e95 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #37404

PR-URL: #37477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Electroid mentioned this pull request May 24, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

BridgeAR BridgeAR left review comments
Trott Trott approved these changes
lpinca lpinca approved these changes
aduh95 aduh95 approved these changes
juanarbol juanarbol approved these changes
+1 more reviewer
Alhadis Alhadis left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Please document FORCE_COLOR/NO_COLOR in node -h output

8 participants

Back | FazBrowse Home | New Git URL