FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add url.resolve replacement example by aduh95 · Pull Request #37501 · nodejs/node · GitHub

/ node Public

doc: add url.resolve replacement example - #37501

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:url-resolve-whatwg
Feb 26, 2021
Merged

doc: add url.resolve replacement example#37501
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:url-resolve-whatwg

Conversation

aduh95 commented Feb 24, 2021

Copy link
Copy Markdown
Contributor

Fixes: #37492

nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Feb 24, 2021
aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 24, 2021
Fixes: nodejs#37492

PR-URL: nodejs#37501
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
aduh95 force-pushed the url-resolve-whatwg branch from 5bddf51 to 5d240c5 Compare February 26, 2021 15:35
aduh95 merged commit 5d240c5 into nodejs:master Feb 26, 2021

aduh95 commented Feb 26, 2021

Copy link
Copy Markdown
Contributor Author

Landed in 5d240c5

aduh95 deleted the url-resolve-whatwg branch February 26, 2021 15:36
targos pushed a commit that referenced this pull request Feb 28, 2021
Fixes: #37492

PR-URL: #37501
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
Fixes: #37492

PR-URL: #37501
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams mentioned this pull request May 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please un-deprecate url.resolve

5 participants


Back | FazBrowse Home | New Git URL