doc: revise premature disclosure text in collborator guide - #37524
Merged
Trott merged 1 commit intoMar 1, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
aduh95
approved these changes
Feb 26, 2021
marsonya
approved these changes
Feb 26, 2021
benjamingr
approved these changes
Feb 27, 2021
RaisinTen
approved these changes
Feb 27, 2021
Copy link
Copy Markdown
Member
|
@Trott nit: in the commit title, dicslosure->disclosure |
Sorry, something went wrong.
Trott
force-pushed
the
premature-disclosure
branch
from
2d9165a to
67045e4
Compare
February 27, 2021 23:06
Flarna
approved these changes
Feb 27, 2021
tniessen
approved these changes
Feb 28, 2021
tniessen
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nit: collborator -> collaborator (title is too long for a commit message anyway)
Sorry, something went wrong.
Trott
force-pushed
the
premature-disclosure
branch
from
67045e4 to
7123513
Compare
February 28, 2021 06:02
Avoid abbreviations and jargon. PR -> pull request, repo -> repository, etc. PR-URL: nodejs#37524 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Trott
force-pushed
the
premature-disclosure
branch
from
7123513 to
2fd1db8
Compare
March 1, 2021 06:39
targos
pushed a commit
that referenced
this pull request
Mar 2, 2021
Avoid abbreviations and jargon. PR -> pull request, repo -> repository, etc. PR-URL: #37524 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Avoid abbreviations and jargon. PR -> pull request, repo -> repository, etc. PR-URL: #37524 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid abbreviations and jargon. PR -> pull request, repo -> repository,
etc.