doc: revise objections section of collaborator guide - #37525
Merged
Trott merged 1 commit intoMar 1, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
aduh95
approved these changes
Feb 26, 2021
marsonya
approved these changes
Feb 26, 2021
targos
approved these changes
Feb 26, 2021
benjamingr
approved these changes
Feb 27, 2021
RaisinTen
approved these changes
Feb 27, 2021
Flarna
approved these changes
Feb 27, 2021
The bold text is overused in this section. This change removes it. It also changes some wording: PR -> pull request, can -> may in a rare instance where "may" is the right choice in our docs, etc. (The recommendation to avoid "may" is because "may" implies permission rather than just ability. Yes, I'm probably the one that changed it from "may" in the first place.) PR-URL: nodejs#37525 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
targos
pushed a commit
that referenced
this pull request
Mar 2, 2021
The bold text is overused in this section. This change removes it. It also changes some wording: PR -> pull request, can -> may in a rare instance where "may" is the right choice in our docs, etc. (The recommendation to avoid "may" is because "may" implies permission rather than just ability. Yes, I'm probably the one that changed it from "may" in the first place.) PR-URL: #37525 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
The bold text is overused in this section. This change removes it. It also changes some wording: PR -> pull request, can -> may in a rare instance where "may" is the right choice in our docs, etc. (The recommendation to avoid "may" is because "may" implies permission rather than just ability. Yes, I'm probably the one that changed it from "may" in the first place.) PR-URL: #37525 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bold text is overused in this section. This change removes it. It
also changes some wording: PR -> pull request, can -> may in a rare
instance where "may" is the right choice in our docs, etc. (The
recommendation to avoid "may" is because "may" implies permission rather
than just ability. Yes, I'm probably the one that changed it from "may"
in the first place.)