FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

crypto: add separate error for INVALID_KEY_TYPE by RaisinTen · Pull Request #37555 · nodejs/node · GitHub

/ node Public

crypto: add separate error for INVALID_KEY_TYPE - #37555

Closed
RaisinTen wants to merge 3 commits into
nodejs:masterfrom
RaisinTen:crypto/add-separate-error-for-INVALID_KEY_TYPE
ConversationCommits (3)ChecksFiles changed
Closed

crypto: add separate error for INVALID_KEY_TYPE#37555
RaisinTen wants to merge 3 commits into
nodejs:masterfrom
RaisinTen:crypto/add-separate-error-for-INVALID_KEY_TYPE

Conversation

RaisinTen commented Mar 1, 2021

Copy link
Copy Markdown
Member

This addresses these TODO comments:

node/src/crypto/crypto_cipher.h

Lines 228 to 231 in e6cbec5

case WebCryptoCipherStatus::INVALID_KEY_TYPE:
// Fall through
// TODO(@jasnell): Separate error for this
case WebCryptoCipherStatus::FAILED: {

node/src/crypto/crypto_keys.h

Lines 348 to 351 in e6cbec5

case WebCryptoKeyExportStatus::INVALID_KEY_TYPE:
// Fall through
// TODO(@jasnell): Separate error for this
case WebCryptoKeyExportStatus::FAILED: {

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Mar 1, 2021

RaisinTen commented Mar 1, 2021

Copy link
Copy Markdown
Member Author

cc @jasnell

nodejs-github-bot commented Mar 1, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36420/

nodejs-github-bot commented Mar 1, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36424/

addaleax approved these changes Mar 1, 2021
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe we could also expand CryptoErrorVector in the future to forward error codes, rather than just plain strings, so that the errors become more programatically accessible?

RaisinTen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 2, 2021

nodejs-github-bot commented Mar 2, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36444/

nodejs-github-bot commented Mar 4, 2021 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36468/ 💛

RaisinTen requested a review from jasnell March 5, 2021 15:24

jasnell commented Mar 5, 2021

Copy link
Copy Markdown
Member

Landed in 03942ca

jasnell closed this Mar 5, 2021
jasnell pushed a commit that referenced this pull request Mar 5, 2021
crypto: add separate error for INVALID_KEY_TYPE
03942ca 
PR-URL: #37555
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
RaisinTen deleted the crypto/add-separate-error-for-INVALID_KEY_TYPE branch March 6, 2021 13:54
RaisinTen mentioned this pull request Mar 7, 2021
Merged
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
crypto: add separate error for INVALID_KEY_TYPE
33180fa 
PR-URL: #37555
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request Mar 16, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL