FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: clarify that columnOffset applies only to the first line by jasnell · Pull Request #37563 · nodejs/node · GitHub

/ node Public

doc: clarify that columnOffset applies only to the first line - #37563

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:clarify-vm-columnoffset
ConversationCommits (1)ChecksFiles changed
Closed

doc: clarify that columnOffset applies only to the first line#37563
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:clarify-vm-columnoffset

Conversation

jasnell commented Mar 1, 2021

Copy link
Copy Markdown
Member

Fixes: #26780

nodejs-github-bot added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels Mar 1, 2021
mcollina approved these changes Mar 5, 2021
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

jasnell added a commit that referenced this pull request Mar 5, 2021
doc: clarify that columnOffset applies only to the first line
ee58b2d 
Fixes: #26780

PR-URL: #37563
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

jasnell commented Mar 5, 2021

Copy link
Copy Markdown
Member Author

Landed in ee58b2d

jasnell closed this Mar 5, 2021
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
doc: clarify that columnOffset applies only to the first line
732d8ca 
Fixes: #26780

PR-URL: #37563
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams mentioned this pull request Mar 16, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
doc: clarify that columnOffset applies only to the first line
1dc7f42 
Fixes: #26780

PR-URL: #37563
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams mentioned this pull request May 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
lpinca lpinca approved these changes
marsonya marsonya approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

VM: options.columnOffset has no effect on column number in stack trace output

5 participants

Back | FazBrowse Home | New Git URL