FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Improve mac coverage with webcrypto tests by obi-el · Pull Request #37571 · nodejs/node · GitHub

/ node Public

Improve mac coverage with webcrypto tests - #37571

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
obi-el:more_mac_tests
Mar 8, 2021
ConversationCommits (1)ChecksFiles changed
Merged

Improve mac coverage with webcrypto tests#37571
aduh95 merged 1 commit into
nodejs:masterfrom
obi-el:more_mac_tests

Conversation

obi-el commented Mar 2, 2021

Copy link
Copy Markdown
Contributor

test: Added webcrypto tests for HMAC to improve the coverage of the file lib/internal/crypto/mac.js

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 2, 2021

aduh95 commented Mar 7, 2021

Copy link
Copy Markdown
Contributor

assert.rejects returns a Promise, we must ensure that Promise is not still pending at the end of the test. You need to either add .then(common.mustCall()) after each assert.rejects calls, or put in an async test function as it's done in the same file below.

obi-el commented Mar 7, 2021

Copy link
Copy Markdown
Contributor Author

assert.rejects returns a Promise, we must ensure that Promise is not still pending at the end of the test. You need to either add .then(common.mustCall()) after each assert.rejects calls, or put in an async test function as it's done in the same file below.

Thanks for the comment, i've made the change

aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 7, 2021

nodejs-github-bot commented Mar 7, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36527/

nodejs-github-bot commented Mar 7, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36529/

nodejs-github-bot commented Mar 8, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36530/

nodejs-github-bot commented Mar 8, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36531/

crypto,test: improve hmac coverage with webcrypto tests
4811210 
PR-URL: nodejs#37571
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

aduh95 commented Mar 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Landed in 4811210, thanks a lot 🎉

aduh95 merged commit 4811210 into nodejs:master Mar 8, 2021
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
crypto,test: improve hmac coverage with webcrypto tests
23d6541 
PR-URL: #37571
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams mentioned this pull request Mar 16, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL