FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: check version number in YAML comments from changelogs by aduh95 · Pull Request #37599 · nodejs/node · GitHub

/ node Public

tools: check version number in YAML comments from changelogs - #37599

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:lint-version-from-changelogs
Mar 6, 2021
Merged

tools: check version number in YAML comments from changelogs#37599
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:lint-version-from-changelogs

Conversation

aduh95 commented Mar 4, 2021

Copy link
Copy Markdown
Contributor

aduh95 added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Mar 4, 2021
nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 4, 2021
aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 4, 2021
aduh95 force-pushed the lint-version-from-changelogs branch from a5dbc78 to a49d403 Compare March 5, 2021 11:05

jasnell commented Mar 5, 2021

Copy link
Copy Markdown
Member

fast-track?

jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 5, 2021
PR-URL: nodejs#37599
Refs: nodejs/remark-preset-lint-node#172
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 force-pushed the lint-version-from-changelogs branch from a49d403 to 8de1e19 Compare March 6, 2021 17:47
aduh95 merged commit 8de1e19 into nodejs:master Mar 6, 2021

aduh95 commented Mar 6, 2021

Copy link
Copy Markdown
Contributor Author

Landed in 8de1e19

aduh95 deleted the lint-version-from-changelogs branch March 6, 2021 17:48
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
PR-URL: #37599
Refs: nodejs/remark-preset-lint-node#172
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos commented May 1, 2021

Copy link
Copy Markdown
Member

marked dont-land-on LTS branches because we don't backport changelog updates

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL