test: fix WPT URL tests that fetch JSON data - #37624
Closed
targos wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
aduh95
approved these changes
Mar 6, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
cjihrig
approved these changes
Mar 6, 2021
Trott
approved these changes
Mar 6, 2021
Copy link
Copy Markdown
Member
Author
|
Failed without intl: 12:01:35 [UNEXPECTED_FAILURE][FAIL] Parsing: <http://ExAmPlE.CoM> against <http://other.com/> 12:01:35 assert_equals: href expected "http://example.com/" but got "http://ExAmPlE.CoM/" 12:01:35 at Test.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/wpt/url/url-constructor.any.js:21:7) 12:01:35 at Test.step (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/wpt/resources/testharness.js:2092:25) 12:01:35 at test (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/wpt/resources/testharness.js:566:30) 12:01:35 at runURLTests (/home/iojs/build/workspace/node-test-commit-linux-containered/test/fixtures/wpt/url/url-constructor.any.js:12:5) 12:01:35 Command: /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/node /home/iojs/build/workspace/node-test-commit-linux-containered/test/wpt/test-url.js url-constructor.any.js I added small-icu requirement to url-constructor.any.js |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
force-pushed
the
fix-wpt-url-tests
branch
2 times, most recently
from
5295032 to
6183089
Compare
March 8, 2021 18:28
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
force-pushed
the
fix-wpt-url-tests
branch
from
6183089 to
519c961
Compare
March 8, 2021 21:01
Copy link
Copy Markdown
Member
Author
|
Missed that url-origin.any.js had the same issue. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
added a commit
that referenced
this pull request
Mar 9, 2021
PR-URL: #37624 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
PR-URL: #37624 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.