test: terminate WPT workers after test completion - #37627
Closed
targos wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
aduh95
reviewed
Mar 6, 2021
Comment thread
test/common/wpt.js
| this.inProgress.delete(filename); | ||
| // Always force termination of the worker. Some tests allocate resources | ||
| // that would otherwise keep it alive. | ||
| this.workers.get(filename).terminate(); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
If it's safe to ignore the Promise status, maybe add an empty catch handler?
Suggested change
| this.workers.get(filename).terminate(); | |
| this.workers.get(filename).terminate().catch(() => {}); |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
This promise can never reject
Lines 344 to 354 in f3d3769
Sorry, something went wrong.
aduh95
approved these changes
Mar 6, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
approved these changes
Mar 6, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
added a commit
that referenced
this pull request
Mar 8, 2021
PR-URL: #37627 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
PR-URL: #37627 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.