FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: clear obsolete FLAKY entries by Trott · Pull Request #37631 · nodejs/node · GitHub

/ node Public

test: clear obsolete FLAKY entries - #37631

Merged
Trott merged 2 commits into
nodejs:masterfrom
Trott:rm-obsolete-flaky
Mar 8, 2021
ConversationCommits (2)ChecksFiles changed
Merged

test: clear obsolete FLAKY entries#37631
Trott merged 2 commits into
nodejs:masterfrom
Trott:rm-obsolete-flaky

Conversation

Trott commented Mar 6, 2021

Copy link
Copy Markdown
Member

test-stream-pipeline-http2 and test-http2-pipe haven't failed for a long time.

Closes: #20750

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 6, 2021
Trott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. http2 Issues or PRs related to the http2 subsystem. stream Issues and PRs related to the stream subsystem. windows Issues and PRs related to the Windows platform. labels Mar 6, 2021

nodejs-github-bot commented Mar 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36514/

nodejs-github-bot commented Mar 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36525/

Trott commented Mar 8, 2021

Copy link
Copy Markdown
Member Author

@nodejs/testing This could use another review.

Trott added 2 commits March 8, 2021 06:24
test: clear FLAKY designation for test-http2-pipe
cd4b095 
It hasn't failed in a long time.

Refs: nodejs#20750

PR-URL: nodejs#37631
Fixes: nodejs#20750
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
test: clear flaky designation for test-stream-pipeline-http2
f108778 
It hasn't failed for a long time.

Closes: nodejs#20750

PR-URL: nodejs#37631
Fixes: nodejs#20750
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Trott force-pushed the rm-obsolete-flaky branch from cf15eac to f108778 Compare March 8, 2021 14:24
Trott merged commit f108778 into nodejs:master Mar 8, 2021

Trott commented Mar 8, 2021

Copy link
Copy Markdown
Member Author

Landed in 8ab6a6c...f108778

Trott deleted the rm-obsolete-flaky branch March 8, 2021 14:25
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
test: clear FLAKY designation for test-http2-pipe
381fb98 
It hasn't failed in a long time.

Refs: #20750

PR-URL: #37631
Fixes: #20750
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
test: clear flaky designation for test-stream-pipeline-http2
d5ff50d 
It hasn't failed for a long time.

Closes: #20750

PR-URL: #37631
Fixes: #20750
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
danielleadams mentioned this pull request Mar 16, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
test: clear FLAKY designation for test-http2-pipe
ed30e52 
It hasn't failed in a long time.

Refs: #20750

PR-URL: #37631
Fixes: #20750
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
targos pushed a commit that referenced this pull request May 1, 2021
test: clear flaky designation for test-stream-pipeline-http2
102d12f 
It hasn't failed for a long time.

Closes: #20750

PR-URL: #37631
Fixes: #20750
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
danielleadams mentioned this pull request May 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ruyadorno ruyadorno approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test Issues and PRs related to the tests with unstable failures on the CI. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flaky: parallel/test-http2-* on Windows

4 participants

Back | FazBrowse Home | New Git URL