FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: document that module.evaluate fulfills as undefined by jasnell · Pull Request #37663 · nodejs/node · GitHub

/ node Public

doc: document that module.evaluate fulfills as undefined - #37663

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-vm-module-eval-promise
ConversationCommits (1)ChecksFiles changed
Closed

doc: document that module.evaluate fulfills as undefined#37663
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-vm-module-eval-promise

Conversation

jasnell commented Mar 9, 2021

Copy link
Copy Markdown
Member

Fixes: #37453
Signed-off-by: James M Snell jasnell@gmail.com

doc: document that module.evaluate fulfills as undefined
8f8d47f 
Fixes: nodejs#37453
Signed-off-by: James M Snell <jasnell@gmail.com>
nodejs-github-bot added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels Mar 9, 2021
jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 9, 2021

jasnell commented Mar 9, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

fast-track? please 👍🏻

jasnell commented Mar 9, 2021

Copy link
Copy Markdown
Member Author

Landed in 16151be

jasnell closed this Mar 9, 2021
jasnell added a commit that referenced this pull request Mar 9, 2021
doc: document that module.evaluate fulfills as undefined
16151be 
Fixes: #37453
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #37663
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
doc: document that module.evaluate fulfills as undefined
60d8afa 
Fixes: #37453
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #37663
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams mentioned this pull request Mar 16, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
doc: document that module.evaluate fulfills as undefined
5ef2a8d 
Fixes: #37453
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #37663
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams mentioned this pull request May 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

marsonya marsonya approved these changes
RaisinTen RaisinTen approved these changes
+1 more reviewer
devsnek devsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot return value from a SourceTextModule to the caller

5 participants

Back | FazBrowse Home | New Git URL