FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add @marsonya as a triager by marsonya · Pull Request #37667 · nodejs/node · GitHub

/ node Public

doc: add @marsonya as a triager - #37667

Closed
marsonya wants to merge 2 commits into
nodejs:masterfrom
marsonya:marsonya-triager
ConversationCommits (2)ChecksFiles changed
Closed

doc: add @marsonya as a triager#37667
marsonya wants to merge 2 commits into
nodejs:masterfrom
marsonya:marsonya-triager

Conversation

marsonya commented Mar 9, 2021

Copy link
Copy Markdown
Member

I would like to apply for the role of a triager in this project.
My motivation to become a triager is to help manage issues, as well as learn deeper concepts of Node.js, and eventually become a collaborator!

I hereby declare that I have read and understood the Code of Conduct and will adhere to that.

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 9, 2021

gireeshpunathil commented Mar 9, 2021

Copy link
Copy Markdown
Member

LGTM. For the context, here is the documentation for triage process and triager role:
https://github.com/nodejs/node/blob/5421e15bdc6122420d90ec462c3622b57d59c9d6/doc/guides/contributing/issues.md#triaging-a-bug-report

targos commented Mar 9, 2021

Copy link
Copy Markdown
Member

@marsonya I suggest that you remove the "@" from your username in the commit message. If the commit lands as is, you will be notified by GitHub everytime it's cherry-picked or pushed somewhere.

marsonya commented Mar 9, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

@marsonya I suggest that you remove the "@" from your username in the commit message. If the commit lands as is, you will be notified by GitHub everytime it's cherry-picked or pushed somewhere.

Thanks for the suggestion. I have made changes and removed the "@" from the commit message.

gireeshpunathil commented Mar 9, 2021

Copy link
Copy Markdown
Member

@marsonya - also pls follow the commit message guidelines documented here - namely:

  • first line starts with the name of a subsystem (in this case doc)
  • followed by : and the message title, not exceeding 50 columns
  • leve a blank line after that
  • next lines should wrap in 72 columns

marsonya closed this Mar 9, 2021
doc: add marsonya as a triager
ee95681 
I would like to apply for the role of a triager in this project. My motivation to become a triager is to help manage issues, as well as learn deeper concepts of Node.js, and eventually become a collaborator! I hereby declare that I have read and understood the Code of Conduct and will adhere to that.
marsonya reopened this Mar 9, 2021

marsonya commented Mar 9, 2021

Copy link
Copy Markdown
Member Author

@marsonya - also pls follow the commit message guidelines documented here - namely:

  • first line starts with the name of a subsystem (in this case doc)
  • followed by : and the message title, not exceeding 50 columns
  • leve a blank line after that
  • next lines should wrap in 72 columns

Apologies for the mess. The commit message was a result of me amending the first commit to remove "@" from commit message. It's all fixed now.

mhdawson approved these changes Mar 10, 2021
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

gireeshpunathil pushed a commit that referenced this pull request Mar 16, 2021
doc: add marsonya as a triager
3bba40a 
I would like to apply for the role of a triager
in this project. My motivation to become a triager
is to help manage issues, as well as learn deeper
concepts of Node.js, and eventually become a
collaborator! I hereby declare that I have read and
understood the Code of Conduct and will adhere to that.

PR-URL: #37667
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>

gireeshpunathil commented Mar 16, 2021

Copy link
Copy Markdown
Member

landed in 3bba40a

gireeshpunathil commented Mar 16, 2021

Copy link
Copy Markdown
Member

sent invitation to @marsonya

marsonya commented Mar 16, 2021

Copy link
Copy Markdown
Member Author

sent invitation to @marsonya

received and accepted! thanks :)

danielleadams pushed a commit that referenced this pull request Mar 16, 2021
doc: add marsonya as a triager
9fad821 
I would like to apply for the role of a triager
in this project. My motivation to become a triager
is to help manage issues, as well as learn deeper
concepts of Node.js, and eventually become a
collaborator! I hereby declare that I have read and
understood the Code of Conduct and will adhere to that.

PR-URL: #37667
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
danielleadams mentioned this pull request Mar 16, 2021
Merged
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
doc: add marsonya as a triager
89f3aa9 
I would like to apply for the role of a triager
in this project. My motivation to become a triager
is to help manage issues, as well as learn deeper
concepts of Node.js, and eventually become a
collaborator! I hereby declare that I have read and
understood the Code of Conduct and will adhere to that.

PR-URL: #37667
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
targos pushed a commit that referenced this pull request May 1, 2021
doc: add marsonya as a triager
6d7c7bc 
I would like to apply for the role of a triager
in this project. My motivation to become a triager
is to help manage issues, as well as learn deeper
concepts of Node.js, and eventually become a
collaborator! I hereby declare that I have read and
understood the Code of Conduct and will adhere to that.

PR-URL: #37667
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
danielleadams mentioned this pull request May 3, 2021
Merged
VoltrexKeyva mentioned this pull request Aug 26, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
gireeshpunathil gireeshpunathil approved these changes
RaisinTen RaisinTen approved these changes
+2 more reviewers
mhdawson mhdawson approved these changes
PoojaDurgad PoojaDurgad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL